canonknipser / viewexif Goto Github PK

Instead of of using the very limited PHP exif library, I would like to switch to PEL

According to a remark from the extensions team, the css should only load on pages which contain attachments, not globally:

<!-- INCLUDECSS @canonknipser_viewexif/viewexif.css -->
Please only include your css on pages it is actually used.

In your changelog you have your 1.0.0 before the beta and RC. Sounds like the wrong order :)

I see the error:
[phpBB Debug] PHP Warning: in file [ROOT]/ext/canonknipser/viewexif/event/main_listener.php on line 136: Division by zero
pop up now and then, not sure why. It doesn't seem to affect anything.

PHPBB 3.2.1 (happened in 3.2.0 as well), PHP 7, viewexif 1.03

local + github

• create milestone 1.1.2

• assign issues to milestone

• inform translators, if there are language file changes

• update changelog

• update composer.json

• create migration to update version number in config

• create zip files for includes translations

• create branch 1.1.2

• close issues assigned to milestone

extension db

• create zip file for Extension DB

• upload zip to Extension DB

• update announcement on Extension DB

• upload translations to Extension DB support area

• wait for validation

canonknipser.com

• upload zip to canonknipser.com
• upload translations to canonknipser.com
• update viewexif_version.json to canonknipser.com
• update announcement on canonknipser.com

When viewing attachments as a guest, some parameters in the user data are not filled.
One of this is the timezone, which must be taken from the board config default timezone, others may be dateformat and language.

• config/services.yml
  - %core.root_path%
  Line 8: please also put this parameter into quotes, like you already did with the service arguments.
• event/main_listener.php
  * @param \phpbb\config $config Config object
  Line 44: you probably meant \phpbb\config\config here.
• Please remove the large block of commented code, lines 311-359.

Insert
$exif_data = [];
after

1. Please indent your code correctly. Your current code is pretty hard to read.
2. Do you really need your language on all pages?
3. None of these are used.
4. If you dont need the code, please remove it. This applies to more locations in your extension.
5. Template var should be fully uppercase.
6. Do you really need your css on all pages?

validation issue: canonknipser/viewexif/event/main_listener.php "n.a." has to be translatable

Problem when calculation the fraction of degrees or minutes of GPS coordinates, reported by lopoto

When trying to enable the ext, but server configuration does not meet to specifications, the messages should give more details about the specific problem.
At the moment the extension has 2 requirements

• phpBB-Version must be greater or equal to 3.1.6
• PHP exif library must be installed

validation issue by david63: There is no log message when the extension's configuration is updated and the naming of the acp_info file is incorrect - they should be info_acp_viewexif.php or they should be loaded. Currently the log enties are not picking up the details of the modules when the extension is enabled.

The gps link should be more flexible and give board owners a chance to pick another service like bing, open street maps

acp module needed for that

Collect all readable metadata from images and store them in a database, so you can filter images etc. depending in their metadata

the extension ńeeds php-exif library, so check if installed

validation issue: remove 3rd parameter from "config.update" in migrations/data_1_1_1.php

change GPL-2.0 to GPL-2.0-only

https://www.phpbb.com/community/viewtopic.php?f=456&t=2373801&p=14443471#p14444231

Interesting extension, but I'm not sure if everyone (I mean forum members) wants to see exif data, so I would like to ask if there is (or could be) option to show/hide exif data.

Maybe in a later version a acp (e.g. by-forum on/off, selected specific exif data to show) and / or ucp (e.g. show / hide exif for displayed attachments, allow / forbid exif for posted attachments) will be added.

mentioned here: https://www.phpbb.com/community/posting.php?mode=reply&f=456&t=2373801#pr14633091

and i suggest to add "cursor:pointer" in div.ck_ve_exifblock in viewexif.css to have hand cursor on hide/show

Open attached images in new window with greyscale background - colour choseable from pure white via grey to pure black in a few (maybe 5 to 7) steps

Reporter: Girello
Samsung mobile phones set ISO Speed Rating as an array, need to pick the first element.

Make sure parameter given to htmlspecialchars are really strings

Extensions should follow a new directory structure - root is only containing non-packed resources, packed resources are in a subfolder named vendor/extension

just hide the "exif"-div via Show/Hide-Click