Git Product home page Git Product logo

Comments (16)

yaili avatar yaili commented on May 16, 2024

@richmccartney Can you provide a screenshot of what @jamiedawsonyoung refers to?

from vanilla-framework.

anthonydillon avatar anthonydillon commented on May 16, 2024

I strongly disagree with changing to default browser dropdown as this
involves rebuilding the browser functionality in divs and js. The browsers
have full assessibilty support which we would have to support if we rebuild
it.

That said we can modify the style of the input (not the dropdown) in
WebKit. This can be seen here as the sort by and series filters;
https://jujucharms.com/store

On Fri, 19 Feb 2016, 12:49 Inayaili de León Persson <
[email protected]> wrote:

@richmccartney https://github.com/richmccartney Can you provide a
screenshot of what @jamiedawsonyoung https://github.com/jamiedawsonyoung
refers to?


Reply to this email directly or view it on GitHub
#171 (comment)
.

from vanilla-framework.

yaili avatar yaili commented on May 16, 2024

Is that not the default WebKit style?

from vanilla-framework.

anthonydillon avatar anthonydillon commented on May 16, 2024

We have increased the padding, changed the background to white instead of
the gradient and added a dark grey border.

On Fri, 19 Feb 2016, 13:03 Inayaili de León Persson <
[email protected]> wrote:

Is that not the default WebKit style?


Reply to this email directly or view it on GitHub
#171 (comment)
.

from vanilla-framework.

yaili avatar yaili commented on May 16, 2024

The only thing that changes on Chrome is the font size that I can see…

I'm guessing @Lucapaulina et al. might come up with suggestions for styles of select elements… I'd like to explore this further.

Some examples to think about:

from vanilla-framework.

anthonydillon avatar anthonydillon commented on May 16, 2024

Sorry here is the styled dropdowns:
https://demo.jujucharms.com/services/?store

from vanilla-framework.

yaili avatar yaili commented on May 16, 2024

Could that not be the default for vanilla? It follows the styles of the other inputs.

from vanilla-framework.

Lucapaulina avatar Lucapaulina commented on May 16, 2024

I can't see why it couldn't be used.

On Fri, Feb 19, 2016 at 2:13 PM Inayaili de León Persson <
[email protected]> wrote:

Could that not be the default for vanilla? It follows the styles of the
other inputs.


Reply to this email directly or view it on GitHub
#171 (comment)
.

from vanilla-framework.

anthonydillon avatar anthonydillon commented on May 16, 2024

Sure we could add it. I'll gather the styles and add them to this issue to
be worked on.

On Fri, 19 Feb 2016, 21:36 Luca Paulina [email protected] wrote:

I can't see why it couldn't be used.

On Fri, Feb 19, 2016 at 2:13 PM Inayaili de León Persson <
[email protected]> wrote:

Could that not be the default for vanilla? It follows the styles of the
other inputs.


Reply to this email directly or view it on GitHub
<
#171 (comment)

.


Reply to this email directly or view it on GitHub
#171 (comment)
.

from vanilla-framework.

richmccartney avatar richmccartney commented on May 16, 2024

Here are the current MAAS GUI styles for select dropdown as per Jamie's original comments. Might help when deciding how these are to look.

screen shot 2016-02-19 at 22 42 55

screen shot 2016-02-19 at 22 42 48

from vanilla-framework.

yaili avatar yaili commented on May 16, 2024

@anthonydillon @jamiedawsonyoung @richmccartney We decided we'd keep default radio and checkboxes for Vanilla. Shouldn't select inputs follow the same rationale in that case?

from vanilla-framework.

anthonydillon avatar anthonydillon commented on May 16, 2024

Oh did we, I thought we were using the positive colour for them. It is a
design decision really.

On Mon, 9 May 2016 at 15:12 Inayaili de León Persson <
[email protected]> wrote:

@anthonydillon https://github.com/anthonydillon @jamiedawsonyoung
https://github.com/jamiedawsonyoung @richmccartney
https://github.com/richmccartney We decided we'd keep default radio and
checkboxes for Vanilla. Shouldn't select inputs follow the same rationale
in that case?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#171 (comment)

from vanilla-framework.

yaili avatar yaili commented on May 16, 2024

Positive colour only for Juju (green) and MAAS (orange).

from vanilla-framework.

jamiedawsonyoung avatar jamiedawsonyoung commented on May 16, 2024

Isn't it a little odd to have a different colour for selection controls for each product? I'm not sure they should be 'branded' I think we could come up with a consistent style for all? (green like Client?) ;-)

from vanilla-framework.

yaili avatar yaili commented on May 16, 2024

Yes, that's what we talked about at the workshop, if I understood correctly. The idea is that we'd leave them as they are for now, but the products should align at some point (soon).

from vanilla-framework.

yaili avatar yaili commented on May 16, 2024

Added wontfix label. Correct me if I understood wrong, but I think the current agreement is that Vanilla will have unstyled checkboxes, radio buttons and select inputs (dropdowns).

from vanilla-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.