OVERVIEW

First, good job on the project and the rockcraft-pack action, it' will definitely be useful.

As more people and teams are building rocks, we also have to publish them somewhere. One of the registries used to publish such container images is Github's container registry. Right now, this is a great place to publish container images as it is well integrated with Github where our code, CI and permissions are already managed. Here the ask is for a new action to publish the created rock to Github's container registry.

This action would fetch the artifact created by the rockcraft-pack action, login to ghcr.io, use skopeo to copy the file to docker-daemon and push it to ghcr.io.

Usage

In terms of API, this could look something like:

    steps:
      - name: Checkout repository
        uses: actions/checkout@v3
      - uses: canonical/craft-actions/rockcraft-publish-ghcr@main
        with: 
          artifact_name: rock
          image_name: banana
          image_version: 1.1.1
          organization: canonical

For this example, the action would have published the container image to ghcr.io/canonical/banana:1.1.1. image_name and image_version could default to values read from rockcraft.yaml and organization could default to canonical so that a minimal API could be:

    steps:
      - name: Checkout repository
        uses: actions/checkout@v3
      - uses: canonical/craft-actions/rockcraft-publish-ghcr@main
        with: 
          artifact_name: rock

Current state

Here's what I have to do right now to take the provided rock and publish it to ghcr.io:

    steps:
      - name: Checkout repository
        uses: actions/checkout@v3

      - name: Log in to the Container registry
        uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
        with:
          registry: ghcr.io
          username: ${{ github.actor }}
          password: ${{ secrets.GITHUB_TOKEN }}

      - name: Install skopeo
        run: |
          sudo snap install --devmode --channel edge skopeo

      - name: Install yq
        run: |
          sudo snap install yq

      - uses: actions/download-artifact@v3
        with:
          name: rock

      - name: Import and push to github package
        run: |
          image_name="$(yq '.name' rockcraft.yaml)"
          version="$(yq '.version' rockcraft.yaml)"
          rock_file=$(ls *.rock | tail -n 1)
          sudo skopeo \
            --insecure-policy \
            copy \
            oci-archive:"${rock_file}" \
            docker-daemon:"ghcr.io/gruyaume/${image_name}:${version}"
          docker push ghcr.io/gruyaume/${image_name}:${version}

Reference

• https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): update development dependencies (minor and patch) (@types/node, esbuild, eslint-plugin-prettier, prettier, ts-jest, typescript, typescript-eslint)
• chore(deps): update dependency @types/node to v20
• chore(deps): update dependency eslint-plugin-github to v5

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update actions/upload-artifact action to v4
• chore(deps): update dependency eslint to v9

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Hello team,

This action installs lxd when installing Rockcraft dependencies.
I see in the code that it's trying to install lxd version 5.9/stable

// Install a specific version of LXD that we know works well with Rockcraft
  const haveSnapLXD = await haveExecutable('/snap/bin/lxd')
  core.info('Installing LXD...')
  await exec.exec('sudo', [
    'snap',
    haveSnapLXD ? 'refresh' : 'install',
    'lxd',
    '--channel',
    '5.9/stable'
  ])

However I'm getting the following error when using this action in our ci:

Installing Rockcraft plus dependencies
  Ensuring runner is in the lxd group...
  /usr/bin/sudo groupadd --force --system lxd
  /usr/bin/sudo usermod --append --groups lxd runner
  Installing LXD...
  /usr/bin/sudo snap refresh lxd --channel 5.[9](https://github.com/canonical/magma-nms-magmalte-rock/actions/runs/4544227705/jobs/8013031187?pr=2#step:3:10)/stable
  error: snap "lxd" is not available on 5.9/stable but is available to install on
         the following channels:
  
         5.9/candidate  snap refresh --channel=5.9/candidate lxd
         5.9/beta       snap refresh --channel=5.9/beta lxd
         5.9/edge       snap refresh --channel=5.9/edge lxd
  
         Please be mindful pre-release channels may include features not
         completely tested or implemented. Get more information with 'snap info
         lxd'.
  Error: The process '/usr/bin/sudo' failed with exit code 1

I tried to install that specific version of lxd manually and I got the same error.

The rockcraft-pack-action provides an output rock (the filename of the rock produced). This is great for CI as reduces the boilerplate code needed to consume the output.

For the same reason, it would be great if this action also provided data like name, version, and probably others. This would make it really easy to chain a rockcraft-pack call with a skopeo copy, etc. A use can currently inspect the rockcraft.yaml file to get this information, but it feels more natural and convenient to be provided these directly from rockcraft-pack-action

Currently the rockcraft-pack action supports choosing the rockcraft channel. We would like to be able to pin to a specific revision.

At the moment, the action automatically packs rocks in the root of the repository where the action is called or from path, assuming the Rockcraft project is there, but there are repositories, for instance pipelines-rocks, where the root of the repository does not contain a Rockcraft project, and there are instead, multiple of them inside different directories.