Comments (3)
Yeah, this change makes sense to me!
from charming-actions.
If there's any worry about always publishing to branches, a compromise would be an optional upload-to-branch-label
argument (or something with a better name). If set, then the action would only upload to branches if the PR has that label (this way PRs can opt-in to branch publishing when it is needed). If unset, then the action would always publish to a branch
from charming-actions.
I think it's fine without that extra precaution as remote PRs won't have access to secrets and hence will fail, so to have this work, repos that want to publish to branches will have to enforce a feature branch based workflow rather than forks.
from charming-actions.
Related Issues (20)
- Enable build charm(s) with cache and reusable charm files to speed up CI runs HOT 3
- Create a new tag for actions with node16 HOT 1
- release-libraries does not work on major version bump HOT 1
- [upload-charm] Add input for specifying retry strategy
- [upload-charm] Upload multiple charms
- Upload-charm action fails to upload logs when packing in destructive mode
- Support charmcraft shared caching HOT 1
- Make `channel` support workflow_dispatch
- Dependency Dashboard
- [upload-charm] always uses the latest revision of the resource HOT 6
- If destructive-mode is disabled, we need to run `lxd init --auto` HOT 1
- `upload-charm` action in 2.6.2 fails to create a release HOT 2
- The channel action does not accept manual workflow triggers
- `upload-bundle` action fails: `'.' is not a file` HOT 4
- [upload-charm] Upload all series/bases of the charm HOT 1
- [release-libraries] silently keeps library non-published if LIBPATCH is too high (it needs to be consecutive)
- allow publish charm on feature branches HOT 2
- [check-libraries] Detect library changes on PR without LIBPATCH bump HOT 1
- Library publishing workflow doesn't like LIBAPI changes
- New Action for uploading file resources
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from charming-actions.