Git Product home page Git Product logo

Comments (2)

ca-scribner avatar ca-scribner commented on September 23, 2024 1

I think the idea when written was that:

  • ch:latest/edge is related to gh:main
  • a PR from gh:branch1 against gh:main logically then goes to ch:latest/edge/branch1
  • a PR from gh:branch1 against gh:someOtherBranch felt strange to put in ch:latest/edge/branch1 because it wasn't related to gh:main
  • it might make sense for a PR from gh:branch1 against gh:someOtherBranch to publish to ch:someOtherBranch/edge/branch1, but that charmhub track often doesn't exist

But, I think @beliaev-maksim brings up a great point: it doesn't really matter what the target of the PR is - the source branch is what matters. So just lumping them all in ch:latest/edge/... doesn't cause a problem

...technically maybe it could cause a problem in some edge case where a PR isn't rebased properly? But that seems like something we shouldn't defend against

from charming-actions.

ca-scribner avatar ca-scribner commented on September 23, 2024

While we're at it, we could I think get rid of all the logic around this channel choosing. prs against gh:track/* can just get lumped into the same place, too

from charming-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.