[BUG] `undefined method `define' for RSpec::Matchers:Module` about cancancan HOT 9 CLOSED

Also, this probably isn't needed since that PR fixes it, but for future reference, in case anybody has issues in the future and googles this:

My spec_helper started with:

require File.dirname(__FILE__) + "/../config/environment" unless defined?(Rails.root)

require 'shoulda'
require 'cancan/matchers'
require 'rspec/rails'
require 'timecop'
require 'webmock/rspec'

...and before this PR, failed unless I added require 'rspec/expectations' right before requireing cancan's matchers - with this PR my spec_helper remains as is.

from cancancan.

This doesn't happen with Rspec 2.13 - something changed between 2.13 and 2.14 that changed this.

If I just add require 'rspec/expectations' to the top of lib/cancan/matchers.rb, it works okay. Not sure if that would break compatibility with other versions of rspec though. Also works if I add that line to my own spec_helper before I require cancan.

from cancancan.

This is on master or 1.7.0?

from cancancan.

bah.. obviously the 1.7.0... sorry... i'll check it out.

from cancancan.

Upon some investigation:

https://github.com/rspec/rspec/commit/15ef280ac74b03f612d6038f484d80226fb38e03

Removed explicitly requiring both expectations and mocks. So it should be fixable by:

Removing

require 'rspec'

and adding

require 'rspec/core'
require 'rspec/expectations'
require 'rspec/mocks'

I'll get this in asap as a patch release.

from cancancan.

@JustinAiken I haven't actually been able to duplicate your issue, no matter where I require cancan/matches ... Could you try running against:

https://github.com/CanCanCommunity/cancancan/tree/feature/fix_rspec

And let me know if that fixes it, either that or paste a minimal spec_helper. Super appreciated!

from cancancan.

@JustinAiken ping?

from cancancan.

Oh, haha... I was bundleing up that ref as you pinged me :)

Yes confirmed - that fixes it :)

from cancancan.

hahaha... great thanks, I'll push a 1.7.1 release today.

from cancancan.