First cue is not removed on disableTextTrack about rx-player HOT 3 CLOSED

Nice! There is definitely a bug in that logic.

Still, your resolution does not seem to return what is expected in some situations:

for the following cues:

const cues = [
  { start: 1, end: 2, element: {} },
  { start: 2, end: 3, element: {} },
  { start: 3, end: 4, element: {} },
  { start: 4, end: 5, element: {} }
];

getCuesBefore is defined as returning all cues strictly before a given time, so it should do:

const before1 = getCuesBefore(cues, 3);
// before1 should only contain the first two cues, as 3-to-4 is not strictly before 3

const before2 = getCuesBefore(cues, 3.5);
// before1 should only contain the first two cues, as 3-to-4 is not strictly before 3.5

But with your modifications, both will include the third cue as their start is inferior or equal to the given time.

I've worked on an implementation that should work (PR #450).
I've written some tests to ensure that it works correctly in all cases.

from rx-player.

Good job! +1 for the tests.

from rx-player.

This issue should be resolved in the v3.10.3

from rx-player.