Git Product home page Git Product logo

spring-boot-file-upload-download-rest-api-example's Issues

Question about the controller

Sorry if I am completely wrong here but I have recently needed to learn the Spring Boot framework for work. I have Java experience but all of my web server stuff has been in Go.

That said I was looking at this line

@PostMapping("/uploadFile")
public UploadFileResponse uploadFile(@RequestParam("file") MultipartFile file) {
DBFile dbFile = DBFileStorageService.storeFile(file);
String fileDownloadUri = ServletUriComponentsBuilder.fromCurrentContextPath()
.path("/downloadFile/")
.path(dbFile.getId())
.toUriString();
return new UploadFileResponse(dbFile.getFileName(), fileDownloadUri,
file.getContentType(), file.getSize());
}
@PostMapping("/uploadMultipleFiles")
public List<UploadFileResponse> uploadMultipleFiles(@RequestParam("files") MultipartFile[] files) {
return Arrays.asList(files)
.stream()
.map(file -> uploadFile(file))
.collect(Collectors.toList());
}

Couldn't that be overloaded like this?

  @PostMapping(value = "/upload", params = {"file"})
  public UploadFileResponse uploadFile(@RequestParam MultipartFile file) {
    FileInstance fileInstance = fileStorageService.storeFile(file);

    String fileDownloadUri = ServletUriComponentsBuilder.fromCurrentContextPath()
      .path("/downloadFile/")
      .path(fileInstance.getId())
      .toUriString();
    
    return new UploadFileResponse(fileInstance.getFileName(), fileDownloadUri,
      file.getContentType(), file.getSize());
  }

  @PostMapping(value = "/upload", params = {"files"})
  public List<UploadFileResponse> uploadFile(@RequestParam MultipartFile[] files) {
    return Arrays.asList(files)
      .stream()
      .map(file -> uploadFile(file))
      .collect(Collectors.toList());
  }

If I am understanding things correctly that should allow a single endpoint to be used and it would auto use the correct upload?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.