Git Product home page Git Product logo

Comments (9)

WyriHaximus avatar WyriHaximus commented on July 23, 2024 1

No problem working on it now.

These are interesting, been mainly using utility classes for things like this but these are actually inside a helper. The Helper element I'm working on should help with these two:

  • autoParagraph => TextHelper::autoParagraph()
  • autoLinkUrls => TextHelper::autoLinkUrls()

from legacy-twig-view.

dereuromark avatar dereuromark commented on July 23, 2024

slightly unrelated
why is number_format not numberFormat
I seems the convention is camelBacked instead of under_scored for 99% of the methods.

from legacy-twig-view.

WyriHaximus avatar WyriHaximus commented on July 23, 2024

the newer ones seem missing as filter:

  • dasherize maps to Cake\Utility\Inflector::dasherize()
  • slug should be Text:slug() as Inflector::slug() is deprecated

also:

  • autoParagraph => TextHelper::autoParagraph()
  • autoLinkUrls => TextHelper::autoLinkUrls()

Will add those through a PR, or are you already working on it?

slightly unrelated
why is number_format not numberFormat
I seems the convention is camelBacked instead of under_scored for 99% of the methods.

Sounds like a good target to fix in the release for cake4

from legacy-twig-view.

dereuromark avatar dereuromark commented on July 23, 2024

Nah, I am busy otherwise. Thanks for looking into it.

from legacy-twig-view.

WyriHaximus avatar WyriHaximus commented on July 23, 2024
  • slug should be Text:slug() as Inflector::slug() is deprecated

Methods look rather different, is the outcome always the same regardless of which I use?

from legacy-twig-view.

ADmad avatar ADmad commented on July 23, 2024

Methods look rather different, is the outcome always the same regardless of which I use?

For amost all practical uses cases it's the same.

from legacy-twig-view.

dereuromark avatar dereuromark commented on July 23, 2024

I tested it and it looked quite similar in my cases, but if we want to make sure for all cases, maybe we should add one and deprecate the other.

from legacy-twig-view.

WyriHaximus avatar WyriHaximus commented on July 23, 2024

Was expecting Inflector::slug() to use Text::slug() internally due to the deprecation

from legacy-twig-view.

WyriHaximus avatar WyriHaximus commented on July 23, 2024

Ok 4.3.6 has been released with the dasherize + @ADmad deprication notice bug fix.

from legacy-twig-view.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.