Update composer.json to allow twig 3.0 about legacy-twig-view HOT 15 CLOSED

Looks like twig-extensions needs a branch for twig 3.0 support as they have 1.x support in the master branch still.

https://github.com/jasny/twig-extensions

from legacy-twig-view.

jasny/twig-extensions now have v1.3 released which supports Twig 3, so we can now move ahead with updating the twig version constraint for TwigView.

from legacy-twig-view.

The other two dependencies aptoma/twig-markdown and asm89/twig-cache-extension will also need a new releases :/

from legacy-twig-view.

aptoma/twig-markdown#34

from legacy-twig-view.

There seems to be an official markdown plugin too https://github.com/twigphp/markdown-extra, so perhaps aptoma/twig-markdown should be replaced with that?

asm89/twig-cache-extension also seems to be unmaintained. It was meant to be replaced by https://github.com/twigphp/twig-cache-extension but even that doesn't have any activity and no releases.

from legacy-twig-view.

I'm using the markdown-extra package with twig 3.

from legacy-twig-view.

Any objections against going 3.0 only?

from legacy-twig-view.

Any objections against going 3.0 only?

None from me. Twig 3 requires 7.2+ which is inline with Cake 4.

from legacy-twig-view.

@WyriHaximus Is the asm89/twig-cache-extension dependency essential for TwigView's working? Cause I don't see it getting updated to support Twig 3 anytime soon.

from legacy-twig-view.

Unless someone has the time and motivation to get asm89/twig-cache-extension or twigphp/twig-cache-extension to do a Twig 3 compatible release the best course of action right now would be simply replace aptoma/twig-markdown with twigphp/markdown-extra and release TwigView 5 without support for Twig 3.

Currently Bake 2.0.0 had to be tagged with while using dev-master of this plugin which isn't very nice. So we need to come up with a short term solution quickly and look into supporting Twig 3 later.

from legacy-twig-view.

@ADmad planned to do it today after dinner :). And no we don't need the cache extensions to work.

from legacy-twig-view.

@WyriHaximus Great to hear.

from legacy-twig-view.

WIP PR: #224

from legacy-twig-view.

@ADmad locally all tests are passing, only need to get the markdown plugin in

from legacy-twig-view.

5.0 is out 🎉

from legacy-twig-view.