cake-build / bakery Goto Github PK

It takes lots of time to shell out to nuget and try to install packages which doesn't exist.

Example, writing #addin Cake.Figlet in VSCode one char at a time will result in trying to install packages C, Ca, Cak etc...

related to #42 which fixed code gen. Documentation is still however missing.

Reproduce with this alias.

public System.Int32 StartProcess(Cake.Core.IO.FilePath fileName, Cake.Core.IO.ProcessSettings settings, out System.Collections.Generic.IEnumerable<System.String> redirectedOutput)
{
    return Cake.Common.ProcessAliases.StartProcess(Context, fileName, settings, out redirectedOutput);
}

ping @patriksvensson

Using VsCode 1.17 with C# 1.13.0-beta4

I added the line

#load nuget:https://www.myget.org/F/cake-contrib/api/v2?package=Cake.Recipe&prerelease

in a .cake file.

Running it the first time worked.

After that, I continued to edit the file.
When I hit Ctrl+Space to get intellisense I noticed another directory of Cake.Recipe was downloaded.

Before:

After:

The complete cake script:

#load nuget:https://www.myget.org/F/cake-contrib/api/v2?package=Cake.Recipe&prerelease

Environment.SetVariableNames();

BuildParameters.SetParameters(context: Context,
                            buildSystem: BuildSystem,
                            sourceDirectoryPath: "./src",
                            title: "Cake.Openshift",
                            repositoryOwner: "cake-contrib",
                            repositoryName: "Cake.Openshift",
                            appVeyorAccountName: "cakecontrib");

BuildParameters.PrintParameters(Context);

ToolSettings.SetToolSettings(context: Context);

Build.RunDotNetCore();

It downloaded another copy of Cake.Recipe only when my cursor was in the method BuildParameters.SetParameters to get more details about more arguments for the method

Then I get the following error:

We should sign the artifacts.

@gep13 could you takevthe lead on this one?

• Push Bakery.exe as tool
• Push Cake.Scripting.Transport as library

Namespace missing from Usings list.

Tested with this simple script:

#addin "Cake.Incubator"

var target = Argument("target", "Default");

Task("Default")
  .Does(() =>
{
  Information(new NUnit3Settings().Dump());
});

RunTarget(target);

But generates the below (actual). Reference generated by Cake.exe (expected).

Make this a required check for merging PR.

Currently we only get the whole buffer from VSCode on updates, so it’s hard to actually know what have been changed. Once LSP us taken into use in C# extension, we will get incremental updates.

We should make sure incremental updates don’t do script analysis and codegen when not needed.

Also, we should figure out how to improve perf when whole buffer is submitted.

I create a minimal test case.

The problem is in intellisense is not working when i reference a dll copiled with .net standard 2.0

The code is avalaible in https://github.com/gabomgp/test-case-bug-bakery

In the code linked, the build.cake is inside a folder with a project in .net standard 2.0. But, the problem is showed too when the build.cake is outside that folder, and inside the solution's folder, where there are other projects, some projects compiled with .net standard 2.0 and others with .net 4.6.

We currently assume all #r directives are file paths.

Right now it searches recursively for Cake.Core.dll.

https://github.com/cake-build/bakery/blob/develop/src/Cake.Scripting/CodeGen/CakeScriptGenerator.cs#L232

We should add a more robust strategy for locating Cake.

Related to https://github.com/cake-build/omnisharp-roslyn/issues/1

No need to try downloading these everytime.

My build.cake has three #load directives. The first one happens to be loading a script ("lib.cake") which OmniSharp is reporting errors for. (It shouldn't be giving errors for that file, but I think it's another case of #86. It's failing to find any of the types I'm using under System.Net.Http.)

In any case, red squiggles are showing up in build.cake which do not line up with actual code and which have the error messages from lib.cake. When I actually open lib.cake, I see the squiggles in the exact same positions on the screen but now as you'd expect they line up with code and the error messages make sense now that they are in context.

After opening lib.cake, the squiggles have disappeared from build.cake.

Add metadata to *.csproj so that it's also available in Assembly Info

So, I've got a super simple script:

var target = Argument("target", "Default");
var configuration = Argument("configuration", "Release");

Task("Default")
.Does(() => {
   Information("Hello Cake!");
   var f = GetFiles("./*.txt");
});

RunTarget(target);

I'm on a Mac.

VSCode extensions:
omnisharp-vscode 1.13.0-beta4
cake-vscode 0.9.0

In tools:
Cake.Bakery 0.1.0
Cake 0.23.0

Omnisharp log:

Starting OmniSharp server at 2017-11-1 13:55:44
    Target: /Users/redth/Desktop/CakeTemp

OmniSharp server started wth Mono
    Path: /Users/redth/.vscode/extensions/ms-vscode.csharp-1.13.0-beta4/.omnisharp/omnisharp/OmniSharp.exe
    PID: 48695

[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Mono 15.0 - "/Library/Frameworks/Mono.framework/Versions/5.4.1/lib/mono/msbuild/15.0/bin"
            2: StandAlone 15.0 - "/Users/redth/.vscode/extensions/ms-vscode.csharp-1.13.0-beta4/.omnisharp/omnisharp/msbuild/15.0/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Mono 15.0 - "/Library/Frameworks/Mono.framework/Versions/5.4.1/lib/mono/msbuild/15.0/bin"
            CscToolPath = /Users/redth/.vscode/extensions/ms-vscode.csharp-1.13.0-beta4/.omnisharp/omnisharp/msbuild/15.0/Bin/Roslyn
            CscToolExe = csc.exe
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/Users/redth/Desktop/CakeTemp'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Found 1 Cake files.
[info]: OmniSharp.Cake.CakeProjectSystem
        Added Cake project '/Users/redth/Desktop/CakeTemp/build.cake' to the workspace.
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Initializing in /Users/redth/Desktop/CakeTemp
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Auto package restore: False
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Update workspace context
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Resolving projects references
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        No solution files found in '/Users/redth/Desktop/CakeTemp'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/Users/redth/Desktop/CakeTemp'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.Stdio.Program
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpWorkspaceOptionsProvider
[info]: OmniSharp.Stdio.Program
        Configuration finished.
[info]: OmniSharp.Stdio.Program
        Omnisharp server running using Stdio at location '/Users/redth/Desktop/CakeTemp' on host 48676.

Basically, I'm getting errors in the script with vscode telling me things have been declared multiple times:

Sometimes after I make some changes I get seemingly random red squigglies like this:

Eventually it goes back to the error with target being already declared.

ping @gep13

See cake-build/cake#1853

I've been following this repository for over a month now but I'm not totally sure what it's supposed to do.
Seems to me to have something to do with intellisense for case scripts but I'm not sure.

Any plans on adding a section on how to use in the readme?

Need to investigate what's causing this..

Transport is dependent on Abstractions v1.0.0, but there no such package.

See issue NuGet/Home#4337 for workaround

See code here https://github.com/mholo65/cake-server/blob/278d5128695b173165c695b7e476218fb4b90ef6/src/Cake.Bakery/Packaging/DefaultPackageInstaller.cs#L78

For reacting to file buffer changes

see example here

ping @patriksvensson

Copyright DNF

Create by e.g. Cake script. Don't use XUnit as in #9

OmniSharp is incorrectly marking ZipFile as not found even though Cake compiles and runs fine.

I've noticed an issue recently that is kind of odd.

If I have a nuget file with some cake files loaded via #addin, everything works correctly the first time. Once I restart vscode and Bakery comes along, I get nested tools directories which causes cake tasks to fail because it loads duplicate tasks.

My directories look like once bakery has done it's thing.

Cleaning the tools directory will solve the problem.

I've seen this in some of my open source stuff as well, I just haven't made a repro yet for it, but will try to to later today.

Create build scripts

//cc @gep13

Currently disabled.

See cake-build/cake#1766

StartProcess get's generated wrong:

Expected:

public System.Int32 StartProcess(Cake.Core.IO.FilePath fileName, Cake.Core.IO.ProcessSettings settings, out System.Collections.Generic.IEnumerable<string> redirectedOutput)
{
    return Cake.Common.ProcessAliases.StartProcess(Context, fileName, settings, out redirectedOutput);
}

Actual:

public System.Int32 StartProcess(Cake.Core.IO.FilePath fileName, Cake.Core.IO.ProcessSettings settings, out System.Collections.Generic.IEnumerable redirectedOutput)
{
    return Cake.Common.ProcessAliases.StartProcess(Context, fileName, settings, out redirectedOutput);
}

//cc @patriksvensson

Shoudl include interfaces, and base entitites...

No need for bakery to install tools