cadixdev / at Goto Github PK

When you have AccessTransform.of(ModifierChange.REMOVE) in an access transform set and write that set using FmlWriter, the resulting AT file contains a broken line starting with -f.

This is not supported by the AT parser and lexer used by FML, which always expects an explicit access modifier as well.

I'm not sure if there's any good way to fix this, though, since it should probably be using the existing visibility of code in question, but that info isn't available here. In Architectury Loom, we just made it default to public-f, but that might also be unwanted.

Or more generally, when there is no explicit MethodMapping for a method, any AT for that method will not have its descriptor remapped, even though the descriptor may contain types which do have mappings.
E.g. remapping from srg to official names:

# Input
public net.minecraft.client.resources.ResourcePackRepository$Entry <init>(Lnet/minecraft/client/resources/ResourcePackRepository;Ljava/io/File;)V # constructor
# Expected
public bnm$a <init>(Lbnm;Ljava/io/File;)V
# Actual
public bnm$a <init>(Lnet/minecraft/client/resources/ResourcePackRepository;Ljava/io/File;)V

The BufferedWriter created at

• Remove any code that depends on Lorenz from:
  • AccessTransformSet
• Move remapping code to either a new package, or module

• README
• Javadocs

See https://www.fabricmc.net/wiki/tutorial:accesswideners

The only blocker I can see with doing this is Methods are made public and final if private.