Git Product home page Git Product logo

cadeyrn / bookmarks-organizer Goto Github PK

View Code? Open in Web Editor NEW
177.0 13.0 31.0 3.57 MB

With the Bookmarks Organizer it's easy to put order in your bookmarks. The Bookmarks Organizer finds no longer working bookmarks, redirects, duplicates and more!

Home Page: https://addons.mozilla.org/en-US/firefox/addon/bookmarks-organizer/

License: Mozilla Public License 2.0

JavaScript 72.78% CSS 19.12% HTML 8.10%
firefox firefox-addon firefox-extension webextension bookmarks manifest-v3

bookmarks-organizer's People

Contributors

cadeyrn avatar coffeemesh avatar dependabot[bot] avatar dlwe avatar eee14 avatar greenkeeper[bot] avatar iwconfig avatar michelepezza avatar perdolka avatar pmichelazzo avatar r0tbra1n avatar smollet777 avatar sopor avatar tarekjor avatar vasimi avatar waldipl avatar yfdyh000 avatar zhtw2013 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bookmarks-organizer's Issues

High memory and processor use without selecting any activity

This problem occurs in FF 52.2.1, running on Windows 7 SP1 (64-bit), installed on a Dell XPS410, with an Intel Core 2 Duo processor and 4 GB RAM.

As soon as the program's icon is clicked, and a new tab opens, FF jumps to 55 - 60 % CPU usage, although it was sitting idle the moment before. This happens before any selection is made from the choices in "Start Here." The high CPU utilization continues as long as the tab remains open, I'm only able to stop it by closing the tab.

Although the three lights in the middle of the interface page light in sequence as though something was happening, no numbers appear on any of the labels at the top of the GUI window to indicate that any bookmarks are being checked.

Over the course of 15 minutes, FF memory usage rises from about 1 GB when opened with 462 tabs, to 2.58 GB.

add bookmarks bulk actions (auto or supervised)

add auto or semi-auto bulk actions to merge, join, diff bookmarks from duplicates considering "folder" and "tags" (#42 #47) fields

For example from bookmark duplicates checker (duplicate criteria: by.url)

ocurrence1: title, url, tag1, folder1
ocurrence2: title, url, tag2, folder2
... etc

possible conflicts

title and url => must be unique (no conflict)
(ignore this 1* ) tag1 & tag2 => resolve ocurrence merged: title, url, tag1, tag2
(1*edit: Firefox considers url.tagged as unique yet, ignore this)
folder1 & folder2 => override (one or another) or convert "folder to tags" (via an folder.2.tags function)

Find folders without name

There is already an option to find bookmarks without name. It should be expanded to find folders without name, too.

improve search field placeholder

from user feedback:

"The search bar that shows up upon completing a scan says 'Name or URL...' It is not immediately obvious that the text typed into this would filter the results shown below. Maybe something like 'Type name or address to filter results' is better?"

URLs falsely marked as "red"

Maybe they were requested too fast or the redirects were not recognized, but many – properly working – bookmarks were marked as non-existent (red) in my test.

encourage users to do a backup

from user feedback:

"If the webextensions API allows for this, offer to create backups, or otherwise encourage the user to create them on their own before they use the add-on to make changes. This could help users from shooting themselves in the foot"

The extension never stops to check my bookmarks

Hi there,

I use Bookmarks Organizer 1.3.0, on Firefox 54.0 (64 bits), and Ubuntu 16.04 64 bits. I have 2086 bookmarks to manage (ok it's a lot, that's why I need to clear them !).

When I run BO for the first time, I have this result :

  • total : 2086
  • checked : 2085
  • warning : ~200
  • errors : ~100 (don't remember the exacts numbers)

Then, I wait... wait... wait, more than 2 hours, and I have never a report of all the bookmarks. It seems freezed.
So I ran again the ckeck. There, it was blocked after 7 bookmarks checked.
I restart Firefox, and after multiple tests, I have never seen a complete report. A every test, it blocked during the analysis, and the screen stays with the 3 bubbles fading in and out.

I don't know if there is a log file to give to you. At the moment, after more than 20 tests, I cannot have a report of my bookmarks, every time it freezes and never give me the hand again ("check bookmarks" button is always disabled after that).

What can I do to find a solution ? How to tell you how to reproduce this ?

Thanks.

FR: Add HTTPS checking

Your extension is perfect for adding HTTPS checking.

By HTTPS checking, I mean checking each bookmark to see if an SSL/TLS page is available.

This will be very valuable.

The only challenge will be to see if the page loads properly with HTTPS. Some sites, when switching to HTTPS from HTTP, are missing images, CSS, or other content. I can provide a couple examples if desired.

improve fox image

from user feedback:

"The fox image on the right in the add-on page is very cute, but the white fur of the fox is too similar to the page background. I couldn't tell what the image was until I right click > View Image'd it. Maybe place it in a circular background for better contrast? This would also help give it the appearance of a button and better convey to users that it is click-able."

Hangs on last item

Beautiful extension. Thank you.

Only trouble is that it seems to hang on the last bookmark.

I seem to recall that this was previously reported, but I'm not seeing the issue report here.

English

I'm sure also users, who do not speak German would like to use your add-on and/or contribute to it. Thus everything on GitHub should be in English: Readme, commit messages, etc.

Make HEAD requests instead of GET requests

Make HEAD requests instead of GET requests for better performance. But be aware: Not every website allows HEAD requests so the second request has to be a GET request. And: Microsoft does send a wrong HTTP status code (Not Found instead of Method not Allowed) so we need to handle this.

Explain errors

For example:

2017-08-07 20 46 23

I aimed to click on the red alert.

Enhancement request

Please, can you make the red alert a button, that lists any error when clicked?

Thanks

Has Problems with other Extensions

I could not get this to work so I created a clean profile where bookmarks-organizer was only extension installed and it worked. I have the following extensions installed
Adblock Plus
Adblock Plus Pop-up Addon
Disconnect
Greasemonkey
LastPass
NoScript
Bookmarks Organizer

I did notice that the window in which this add on executes also has the NoScript red circle around it but does not give the option to unblock any script that could be running

wrong redirects for old google group links

http://groups.google.com/group/de.sci.electronics/browse_thread/thread/22db784b21986df6/2c1d4329e4d73835

redirects to

https://groups.google.com/forum/#!topic/de.sci.electronics/Itt4SyGYbfY

But the Bookmarks Organizer wants to change the url to

https://groups.google.com/forum/

The reason is that the fragment is omitted in the redirected response object of the fetch API. There is no way around this so I have to implement a workaround for Google Groups and hope there are no other websites which need that.

Request

I wanted to request the ability to easily select multiple bookmarks listed to exclude. For example clicking on a folder will give you the option to delete them or exclude them temporary or permanently. Right clicking on a bookmark or clicking on a checkbox or something like that will give you the options to exclude that domain permanently or temporarily or delete all the bookmarks from that domain (that are listed as broken or that need redirect).

Does not work with 0 bookmarks

Of course, with 0 bookmarks there is no bookmark which can be broken and it does not make much sense to run the add-on. But still, the add-on should not get stuck in a broken state.

Conflict with some legacy addons

Fx Version: 56.0b3 (64-bit)

Repro:

  1. install bookmark organizer and this one https://addons.mozilla.org/en-US/firefox/addon/pagesaver/
  2. Open bookmark organizer UI

What happened: it never finishes loading the bookmarks. Errors in browser console:

Attempt to create privileged extension parent from incorrect child process  ExtensionParent.jsm:646
	createProxyContext resource://gre/modules/ExtensionParent.jsm:646:15
	receiveMessage resource://gre/modules/ExtensionParent.jsm:598:11
Error: Could not establish connection. Receiving end does not exist.  undefined

This add-on is not the only one have this problem. So far I found a batch of them, such as xthunder etc.

I suspect all the non-e10s compatible legacy addons will cause this.

Also this is a regression, I always have those conflict addons installed, but bookmark organizers only stops to work recently.

Ticking "Prevent this page from..." disables delete

When trying to delete a bookmark, if the confirmation dialogue includes "Prevent this page from creating additional dialogs" and you tick that option, "delete" appears to stop working (i.e. clicking on "delete" has no effect) until you get the add-on to rescan all your bookmarks.

2017-10-04 11_12_52-2017-10-04 10_57_27-bookmarks organizer edit

Links falsely detected as broken.

I've got 2 bookmarks that are always detected as broken, although the URLs are accessible.
This problem first occurred after the update to Bookmark Organizer 1.3.0.

The relevant debug information:

 {
    "bookmark": {
      "id": "D2zuHRJbKXiJ",
      "parentId": "dFAv3XE2qmPY",
      "title": "Online regex tester and debugger",
      "url": "https://regex101.com/",
      "status": 404
    },
    "method": "HEAD",
    "cause": "server-response",
    "response": {
      "url": "https://regex101.com/",
      "redirected": false,
      "status": 404
    }
  }
 {
    "bookmark": {
      "id": "odolJCrc9izD",
      "parentId": "JK5TPRGCuf1L",
      "title": "FanficAuthors.net",
      "url": "https://www.fanficauthors.net/",
      "status": 404
    },
    "method": "HEAD",
    "cause": "server-response",
    "response": {
      "url": "https://www.fanficauthors.net/",
      "redirected": false,
      "status": 404
    }
  }

quick fix for http -> https

There is already an option to repair all redirects. A new option could be introduced to only repair http to https conversions.

investigate compatibility issue with Keefox

from user feedback:

"Every time I clicked edit for a bookmark and then clicked Save, the Keefox popup showed up and tried to 'save the login.' Could this be fixed on your end or is it an issue with Keefox?"

offset and limit support

Investigate if it's possible and a good idea to implement options for offset and limit. For example: check 200 bookmarks, starting from bookmark 420.

bookmarks tags support (Firefox Places)

Please add tags support for this WebExtension on Firefox (tags is a exclusive Firefox Places feature but it is supported by Pinboard or Delicious and clones SemanticScuttle or Shaarli)

*this solves this issue too (#47)

Duplicate check don't stop.

In Firefox 57 beta(already release),Duplicate check Bookmarks doesn't end.
In JA Location.

Firefox57 BetaはほとんどReleaseですが、Duplicate Checkが終わりません。日本語環境です。

Whitelist

A whitelist should be added to exclude bookmarks from future scans.

bulk repair / deletion for a folder

It's already possible to delete or to repair either a single bookmark or all broken bookmarks. It should be possible to apply these operations to a folder.

Feedback

Hi , noice addon ( ͡° ͜ʖ ͡°)
Works fine if I completely disable noscript but i think it could use some customizable advanced settings
(timeout,max requests etc.) if possible
2 more suggestions:

Not sure about the last one but would be a nice feature
Thanks , this helped me find about 1k problem bookmarks

One click update for all bookmark page titles

While scanning all bookmarks, it would be great if you could replace outdated bookmark page titles with the newest page title. So, basically the name or the heading for each bookmark. At the moment, only the URL is updated and you may still have the outdated bookmark page title.

There's an app that does it, but only one tab at a time. It would be great if this extension could be combined with the features of the app below to scan all bookmark headings in one go.

https://addons.mozilla.org/en-GB/firefox/addon/replace-bookmark/

compact design is not really compact

from user feedback:

"Once the results of a scan for 'missing bookmark names' show up, scroll down a bit so that the header changed from class default to compact. This compact mode doesn't feel compact enough. For example, a resolution of 1366x768 gives me a content area of ~630px on Firefox. But even with the header in .compact mode, I'm left with the results displaying within a height of ~400px. So (230/630)*100=36% of the content area is being spent in showing the header / footer and that action bar with the drop down and the 'check bookmarks' button. Maybe make the action bar and footer a little smaller, and maybe have (at least the compact mode of) the header change the list ' Number of bookmarks', 'Checked', 'Errors' etc. into a horizontal one instead of a vertical one to save vertical space. There is already a lot of empty space in the compact mode of the header between the star on the left and this list on the right."

Reports some URLs as broken when they are not

Overall, the extension works well. Thank you!

However, the extension reports some URLs as unavailable (red dot) when they are not. It seems to be random. There are not particular URLs it happens with. Running the extension immediately again (looking for broken bookmarks) will find different bookmarks as broken, and will not find previously reported broken bookmarks.

My workaround is to click on each reported broken bookmark to see if it is actually broken. Sometimes they are... sometimes they are not.

Option to ignore http -> https redirects from warnings in error check

I was suprised how many of my bookmarks have a "warning" when I check whether they are still available. I noticed most of the redirect to the very same page just appending the s to http.
In order to see relevant warnings, I would like to be able to filter those redirects.
It would also be nice if one could click "warning" or "error" and then omit findings from the other category.

Thanks

Make use of optional permissions

Make use of optional permissions and don't ask for all permissions on install. It will require Firefox 55, so it cannot be implemented before 2017-08-08.

Action for some/all duplicates

While all broken links can be deleted at once, the duplicate finder has no bulk action.
I could imagine to prefer the bookmarks in one folder over the other (e.g. if there are duplicates keep the ones in "toolbar" and drop the ones in "my old bookmarks").
In addition one could want to always keep the newer ones and drop the older bookmarks.

Bookmark Checker gets stuck on last bookmark

from user feedback:

"Sadly I haven't really been able to get much use from the add-on, as the broken bookmark checker always gets stuck on the last bookmark. From a glance at the console output it's possible that it could be due to a basic auth prompt, but I'm not sure and would happily help to find out."

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.