Git Product home page Git Product logo

ccc-roam-pdf-2's People

Contributors

c3founder avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

ccc-roam-pdf-2's Issues

Very slow to open pdfs

It takes a long time and a few restarts to open pdf files after the extension is installed. Is there a way to troubleshhot?

Is this suppose to work encrypted graph?

Great tool and it could make this work on the unencrypted graph. But dragging a PDF file into an encrypted graph, it just brings up the Roam native PDF viewer instead of yours

Settings option to define placement of highlights

Hi,
I've always wondered why you prefer to make a sibling block to the header under which the pdf is embedded. I would prefer to have highlights embedded as children to the pdf, or perhaps the header, but not siblings to the header.
In the case that prompted this query, I have two pdfs embedded as children under a heading.
The highlights of the first pdf appear under the defined header, which is a sibling to the header above the pdf.
The highlights of the second pdf don't appear at all.
Could this be configurable?

Extension could not save new outlines

Found a small bug about left side Panel button.
If previous uploaded PDF did not have the outlines, we can add outline by the 『+add Outline』button.
After saving some outlines and we reloaded the PDF files. All of the outlines we added were gone. It seems not to save now.
Example like the YT link.
https://youtu.be/l-uhqkSG2eo

Clipboard is one highlight behind

Under "copy block ref" and "print nothing" setting sometimes the clipboard is one highlight behind and console shows this:

/#/app/Integration-o…ls/page/WPB1FfhCv:1 Uncaught (in promise) DOMException: Must be handling a user gesture to use custom clipboard

Maybe another small bug about bi-direction comment

1. a Highlight sentence that was not commented by the comment button
2. If I want to comment this Highlight sentence via the R’t side bar of Red Box and text 『Test』and It did not auto-transfer the 『Test』to the Comment of this highlight sentence
3. The only way to transfer the Red Box’s comment to the Highlight comment is that we click the Highlight sentence’s comment button.After the comment box showed up, we continue to click the Red box’s comment button. The 『Test』will be transfered to the comment box. When we clicked save button, the Red box of R’t sidebar will have double the same comment text(『Test』)

https://www.youtube.com/watch?v=WoZsYqoClDM

Replace with Text Doesn't Work

The issue is intermittent but clicking on the icon on a highlight doesn't do anything. I just got this tool and I've used it for two PDFs and I'm seeing the same behavior on both.
image

commenting on highlights does not work

I did not dive into the code but it seems like commenting on a highlight fails if no "Display Name" (I guess that is :edit/user?) is set for the graph? Maybe falling back to "Anonymous" would be an option?

20359eb3-467d-4d54-8638-62b93ecb501c:1218 Uncaught (in promise) TypeError: Cannot read properties of null (reading ':edit/user')
    at getLastEditedUser (20359eb3-467d-4d54-8638-62b93ecb501c:1218:24)
    at 20359eb3-467d-4d54-8638-62b93ecb501c:564:36
    at Array.map (<anonymous>)
    at commentHighlight (20359eb3-467d-4d54-8638-62b93ecb501c:563:30)

Should be reproducible on a new graph (both Browser and Electron App, tested only on Linux) without setting the "Display Name" in the settings.

Even when testing in a graph where the Display Name is set I get an error when commenting:

main.js:9771 no component
App.js:426 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'getReplies')
    at App.js:426:39
    at s (main.f5ae81af.chunk.js:1:2552)
    at Generator._invoke (main.f5ae81af.chunk.js:1:2305)
    at Generator.next (main.f5ae81af.chunk.js:1:2911)
    at r (asyncToGenerator.js:3:1)
    at l (asyncToGenerator.js:25:1)
    at asyncToGenerator.js:32:1
    at new Promise (<anonymous>)
    at asyncToGenerator.js:21:1
    at App.js:66:12

Not sure if I'm doing something wrong, but commenting does not work on all in my graphs. If it helps I can try to record a video..

Unable to import highlights

Should the extension be able to extract highlights that I made in another application? Seemed like it should from your tutorial, but when I do it, the highlights don't get extracted. I noticed this error in the developer console: refused to get unsafe header "Content-Range"

css options to make highlight buttons invisible

Some only interact with the highlights only through the iframe. They want to be able to remove delete/comment/replace with text buttons. And/Or always display the "jump to highlight" button.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.