c0nw0nk / garrys-mod-family-sharing Goto Github PK

[ERROR] lua/autorun/familysharing.lua:264: FamilySharing: Invalid Steam API response for 0 | steamid

1. error - [C]:-1
2. onsuccess - lua/autorun/familysharing.lua:264
   3. unknown - lua/includes/modules/http.lua:35

Posting this as a todo issue for myself for another time.

Based of my following solution that allows both family shared and the account that is the owner of that shared accounts games to be unbanned at the same time. #2 (comment)

When IP Ban setting is enabled, To allow IP addresses to be unbanned add / modify the offence on banhook via

RunConsoleCommand("ulx", "banid", lenderSteamID, time, offence .. "| IP:1.2.3.4")

Do regex check $ for end of offence reason where matched | IP:.*$

And on unban hook get the IP if exists from offence reason to unban their IP too.

if ply:query(string.lower(commandName)) and string.lower(commandName) == "ulx unban" then
--do stuff if global ipban setting enabled then allow users to also have their ip's removed from banlist if found
--pull the IP from the ban reason on the matching STEAMID
RunConsoleCommand("removeip 1.2.3.4")
RunConsoleCommand("writeip")
end

Is this right?
[ERROR] lua/autorun/familysharing.lua:166: FamilySharing: Failed API call for
(Error: unsuccessful)

1. error - [C]:-1
2. onfailure - lua/autorun/familysharing.lua:166
   3. unknown - lua/includes/modules/http.lua:42

I have seen users with shared account that has been banned on their main.

Hey so some guy on my friends list just sent this to me for unrelated reasons and I noticed that it's a shared file, and you're asking the server owner to put their steam API key near the top of the file.

This means that anyone who connects to the server will download a copy of the file containing the steam API key, so they can simply open the file, and find the API key.
You should really put this in a different file which is serverside only.

Also you should probably stop making all the config variables global, because if some other mod happens to make global variables with the same name, it'll break your entire addon (See #6 )

So, the ban script works pretty well, but I've had to disable the banIP setting because of a glaring issue. When a user is banned from the game, whether that be a day ban or a permanent, it always says the same message: "Disconnect: added to the banned list". I don't know if that was intentional but I do not want that to be the ban screen of all users that are banned because it isn't very informative and most importantly, it doesn't give the link to our website in case if their ban was false and they need to dispute it. I understand that that reason "added to the banned list" is what happens when you get IP banned but is there a way you could delay it so first it bans the acc/ID so the ban screen we made for them can be viewed then the IP ban is taken into effect because I do want the IP ban setting on, it helps with keeping the alts away but I don't want it at the cost of the custom ban screen.

Also, I'd just like some clarification on how the unbanning of an account when IP ban is enabled because sometimes I have to unban the IP too since it doesn't unban immediately when I run ulx unban (id).

Thanks for reading.

Getting this error in console when players join the server:

[anti_family_sharing] addons/anti_family_sharing/lua/autorun/server/sv_familysharing.lua:146: FamilySharing: Invalid Steam API response for rat when it sees sugar reward: | STEAM_0:1:30918607
  1. error - [C]:-1
   2. onsuccess - addons/anti_family_sharing/lua/autorun/server/sv_familysharing.lua:146
    3. unknown - lua/includes/modules/http.lua:29
[anti_family_sharing] addons/anti_family_sharing/lua/autorun/server/sv_familysharing.lua:146: FamilySharing: Invalid Steam API response for rat when it sees sugar reward: | STEAM_0:1:30918607
  1. error - [C]:-1
   2. onsuccess - addons/anti_family_sharing/lua/autorun/server/sv_familysharing.lua:146
    3. unknown - lua/includes/modules/http.lua:29

I am using the most recent version of the addon (installed yesterday). Here are my config settings:

SteamFamilySharing.APIKey = "<redacted (double checked)>"

SteamFamilySharing.kickmessage = "The account that lent you Garry's Mod is banned on this server"

SteamFamilySharing.banbypass = true

SteamFamilySharing.banlength = 0

SteamFamilySharing.banreason = "attempting to bypass a current/existing ban."

SteamFamilySharing.banip = true

SteamFamilySharing.blockfamilysharing = true

SteamFamilySharing.blockfamilysharingmessage = "Please connect to the server by a account that own's Garry's Mod."

SteamFamilySharing.extra_ban_checks = true

SteamFamilySharing.informative_ban_message = true

SteamFamilySharing.custom_ban_message = "You're banned!"

SteamFamilySharing.storage_path = "materials/"
SteamFamilySharing.file_type = ".vtf"
SteamFamilySharing.file_name = "car_as14"

local ban_tracker = true

Where can i find the logs of
--Log to server console who has been detected family sharing.
print(string.format("FamilySharing: %s | %s has been lent Garry's Mod by %s",
I can't find it in ulx-logs
I did not have logs enabled in commandline.

https://wiki.facepunch.com/gmod/Player:OwnerSteamID64
Thanks :)

Wouldn't having all the setting variables be global cause issues?

How to unban someone again?

https://github.com/C0nw0nk/Garrys-Mod-Family-Sharing/blob/master/garrysmod/lua/autorun/familysharing.lua#L17

People could just be stealing your API if they dumped the server with scripthook or any other stuff, what's the fucking point?