byxorna / collins-cli Goto Github PK

Could do with some code reuse between the different verbs to collins.

related: #7

With the release of collins-cli-0.2.12 I was very excited to be able to get results from multiple collins servers by querying a single one.

It generally appears to work, so thank you very much to everyone who made that possible!

I did manage to run into an odd corner case:

collins find --remote-lookup --link -n <some nodeclass>

The resulting URLs all point to the collins instance queried, not accurate URLs to whichever is the actual collins instance where they live.

CC @michaeljs1990

(Originally incorrectly filed as tumblr/collins#583)

Could be neat to integrate the collinsdc functionality from this bash snippet to manage personal configs.

collinsdc() {
  if [[ -z $1 ]] ; then
    l=$(basename $(readlink ~/.collins.yml))
    echo "${l##.collins.yml.}"
  else
    if [[ ! -f ~/.collins.yml.$1 ]] ; then
      echo "No collins config found for $1" >&2
      return 2
    fi
    ln -sfn ~/.collins.yml.$1 ~/.collins.yml && echo "Using collins config for $1"
  fi
}

Hi,

looks like the attribute values gets interpreted as format string somehow:

$ collins modify -t "$tag" -a "test:%"
precision given twice

$ collins modify -t "$tag" -a "test:something where % is contained"
too few arguments

It looks like the client isn't doing anything special, so I suspect a issue with collins-client but couldn't find anything obvious. I'll try to reproduce this with only collins-client tomorrow and will move issue if it's a upstream problem.