Git Product home page Git Product logo

Comments (3)

tonyofbyteball avatar tonyofbyteball commented on July 28, 2024

it's actually good that it fails when there are extraneous fields, so we'll know it immediately. validation.js also checks for them.

from ocore.

fitzn avatar fitzn commented on July 28, 2024

Okay - my intuition is that the hashes will fail to line up but they will fail "silently" without any indication of failing. Units will hash to different values without warning. So, the system will break but not explicitly due to mismatched hashes.

Feel free to resolve this issue, though, as I may be misunderstanding.

from ocore.

fitzn avatar fitzn commented on July 28, 2024

I see now. validation.js:validate throws an Exception (callbacks.ifUnitError) on unknown fields being present.

This makes sense. I do feel it's easier to reason about the unit's hash inputs if they are explicitly copied but that's a style question, I suppose, not a correctness question.

Resolving this.

from ocore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.