Git Product home page Git Product logo

Comments (3)

ClareLau61803 avatar ClareLau61803 commented on July 29, 2024

issue code:
if (amount){
if (typeof amount !== 'number')
throw Error('amount must be a number');
if (amount < 0)
throw Error('amount must be positive');
}

from ocore.

Papabyte avatar Papabyte commented on July 29, 2024

Such a try should result on a validation error at this point of code:
https://github.com/byteball/ocore/blob/master/composer.js#L651
with something like Validation error: amount must be positive integer, found 996741.7 returned as error.
It's before broadcasting or writing into database so I don't understand the consequences you are talking about.
It should be appropriate though to add a check for integer directly in sendMultiPayment function.

from ocore.

tarmo888 avatar tarmo888 commented on July 29, 2024

All amounts are integer, in the smallest unit (bytes). There is no decimals.

from ocore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.