Comments (6)
BurntSushi
commented on May 18, 2024
Uh... That seems surprising to me and sounds like a bug. cc @cholcombe973
from memchr.
cholcombe973
commented on May 18, 2024
Yeah I seem to recall the problem was if I didn't return the needle position plus one it would get stuck in a infinite loop.
from memchr.
BurntSushi
commented on May 18, 2024
sigh OK. Returning the index + 1 doesn't seem right to me at all. I really wish I caught that.
This has to be fixed. The question now is whether this requires a 2.0.0 release. It probably does.
from memchr.
cholcombe973
commented on May 18, 2024
It seemed right at the time :-/. I think I was using it to split strings.
from memchr.
matt2xu
commented on May 18, 2024
Any update on this? It would be nice to be zero-based IMO.
from memchr.
BurntSushi
commented on May 18, 2024
Fixed in #18. Note that we decided it would be best to do a memchr 2 release for this change.
from memchr.
Related Issues (20)
- Use of `AtomicPtr` in `unsafe_ifunc` prevents memchr from being inlined when compiled with avx enabled HOT 4
- Error building for arm64 on a am64 with docker HOT 2
- Provide const implementation HOT 4
- Poor performance on Zen 1/Threadripper due to loop unrolling HOT 4
- Build script flagged as Virus by Kaspersky Endpoint Security HOT 1
- memchr 2.5.0 fails to compile on Android HOT 3
- Runtime configuration of byte frequency table used to classify rare bytes HOT 10
- Feature request: no-std + alloc HOT 3
- no-std + cpu feature detection? HOT 5
- failed to compile `memchr 2.5.0` on macos-12 and macos-11 HOT 2
- `Memchr<'_>` is no longer `Sync` from v2.6 HOT 2
- consider semver-checks HOT 8
- New SIMD improvements break MSRV for aarch64 targets HOT 2
- Update Cargo.toml `package.description` HOT 1
- Duplicate lang items with 2/more crates depended on this in Cargo.toml and -Zbuild-std HOT 6
- api argument order inconsitant HOT 2
- Potential use of `core::hint::unreachable_unchecked` to avoid bounds checks for all users HOT 2
- Consider implementing memchr with arbitrary char predicate HOT 4
- Error when building `memchr` with custom rustflags `-static` HOT 2
- [Windows 10] Failed to run custom build command for 'memchr v2.4.1' HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memchr.