burntime / atom-monokai Goto Github PK

In atom-monokai\index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• .tab-bar .tab, .tab-bar .tab.active => .tab-bar .syntax--tab, .tab-bar .syntax--tab.active

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

I can open a PR if you want, too.

I'm not sure where it comes from in the fairly small syntax-variables.less file, but when I'm looking at Python source using MagicPython (the not-broken maybe-soon-to-replace atom/language-python highlighter), all the built-in names that are colored by Atom Dark using the support class aren't. Not sure if it's some funky interaction between the two packages, but had to pick somewhere to complain :D

There is an active tab background glitch on on dark and light ui theme:

I am creating a PR for this #5

The title sums it up. They should appear as dark grey but they look very bright.

You can see it in the screenshot on README too

Hi,

I'm using Atom 1.0.19 in my Linux Mint 17.3 One Dark UI Theme configured. I installed Atom Monokai syntax theme but it looks like the scrollbars for One Dark UI aren't correctly styled. Horizontal and vertical scrollbars appear white as if One Light UI Theme was configured.

This is how it looks: Screenshot

What could be the issue?

Thanks!

Atom    : 1.14.1 (x64)
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0
OS      : Windows 10 Pro (64 Bits)

UI Theme: One Dark

Atom Monokai:

One Dark:

[Enter steps to reproduce below:]

1. Install and activate Atom Material UI (https://atom.io/themes/atom-material-ui)
2. Install atom-monokai and attempt to activate

Atom Version: 1.6.0
System: Mac OS X 10.11
Thrown From: atom-monokai package, v0.10.1

Stack Trace

Failed to activate the atom-monokai theme

At Recursive variable definition for @text-color in /Users/anshumanf/.atom/packages/atom-monokai/index.less:0:8

LessError: Recursive variable definition for @text-color
  at /Users/anshumanf/.atom/packages/atom-monokai/index.less:0:8

Commands

     -9:53.2.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -9:53 core:confirm (atom-text-editor.editor.mini.is-focused)
     -9:29.8.0 pane:split-down (a.link)
     -9:23 pane:close (ul.list-inline.tab-bar.inset-panel)
  2x -8:59.2.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -8:57.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  4x -7:30.3.0 core:backspace (atom-text-editor.editor.mini.is-focused)
  2x -7:29.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  4x -3:47.1.0 core:backspace (atom-text-editor.editor.mini.is-focused)
  2x -3:44.5.0 editor:move-to-first-character-of-line (atom-text-editor.editor.mini.is-focused)
     -3:41.6.0 core:select-all (atom-text-editor.editor.mini.is-focused)
     -3:40.6.0 core:cut (atom-text-editor.editor.mini.is-focused)
     -3:34.2.0 core:paste (atom-text-editor.editor.mini.is-focused)
  3x -3:34 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "customFileTypes": {
      "source.ini": [
        ".buckconfig",
        ".flowconfig"
      ],
      "source.json": [
        ".arcconfig"
      ],
      "source.python": [
        "BUCK"
      ]
    },
    "themes": [
      "atom-material-ui",
      "atom-monokai"
    ]
  }
}

Installed Packages

# User
Sublime-Style-Column-Selection, v1.5.1
atom-material-ui, v1.2.8
atom-ternjs, v0.13.2
autoclose-html, v0.23.0
highlight-selected, v0.11.2
linter, v1.11.3
linter-eslint, v7.1.1
minimap, v4.21.0
minimap-highlight-selected, v4.4.0
pigments, v0.24.5
react, v0.14.1

# Dev
No dev packages

In atom-monokai/index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• .atom-text-editor, :host => .atom-text-editor,atom-text-editor

• .atom-text-editor .invisible-character, :host .invisible-character, .atom-text-editor .indent-guide, :host .indent-guide => .atom-text-editor .invisible-character,atom-text-editor .invisible-character, .atom-text-editor .indent-guide,atom-text-editor .indent-guide

• .atom-text-editor .gutter, :host .gutter => .atom-text-editor .gutter,atom-text-editor .gutter

• .atom-text-editor .gutter .line-number, :host .gutter .line-number => .atom-text-editor .gutter .line-number,atom-text-editor .gutter .line-number

• .atom-text-editor .gutter .line-number.folded, :host .gutter .line-number.folded, .atom-text-editor .gutter .line-number:after, :host .gutter .line-number:after, .atom-text-editor .fold-marker:after, :host .fold-marker:after => .atom-text-editor .gutter .line-number.folded,atom-text-editor .gutter .line-number.folded, .atom-text-editor .gutter .line-number:after,atom-text-editor .gutter .line-number:after, .atom-text-editor .fold-marker:after,atom-text-editor .fold-marker:after

• .atom-text-editor .selection .region, :host .selection .region => .atom-text-editor .selection .region,atom-text-editor .selection .region

• .atom-text-editor .highlights .current-result .region, :host .highlights .current-result .region => .atom-text-editor .highlights .current-result .region,atom-text-editor .highlights .current-result .region

• .atom-text-editor .highlights .find-result .region, :host .highlights .find-result .region => .atom-text-editor .highlights .find-result .region,atom-text-editor .highlights .find-result .region

• .atom-text-editor .line-number.cursor-line-no-selection, :host .line-number.cursor-line-no-selection => .atom-text-editor .line-number.cursor-line-no-selection,atom-text-editor .line-number.cursor-line-no-selection

• .comment => .syntax--comment

• .entity => .syntax--entity

• .keyword => .syntax--keyword

• .storage => .syntax--storage

• .storage.type, .support.type.stdint, .support.type.sys-types => .syntax--storage.syntax--type, .syntax--support.syntax--type.syntax--stdint, .syntax--support.syntax--type.syntax--sys-types

• .support.function.any-method, .support.function.C99 => .syntax--support.syntax--function.syntax--any-method, .syntax--support.syntax--function.syntax--C99

• .support.type.exception => .syntax--support.syntax--type.syntax--exception

• .constant => .syntax--constant

• .constant.numeric, .constant.boolean => .syntax--constant.syntax--numeric, .syntax--constant.syntax--boolean

• .variable => .syntax--variable

• .delimiter, .brace => .syntax--delimiter, .syntax--brace

• .invalid.deprecated => .syntax--invalid.syntax--deprecated

• .invalid.illegal => .syntax--invalid.syntax--illegal

• .string => .syntax--string

• .string .constant.character.escape => .syntax--string .syntax--constant.syntax--character.syntax--escape

• .string.regexp => .syntax--string.syntax--regexp

• .string.regexp .source.ruby.embedded, .string.regexp .string.regexp.arbitrary-repitition => .syntax--string.syntax--regexp .syntax--source.syntax--ruby.syntax--embedded, .syntax--string.syntax--regexp .syntax--string.syntax--regexp.syntax--arbitrary-repitition

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Atom Version 0.196.0
Store package style sheets in the styles/ directory instead of stylesheets/ in the atom-monokai package

ThemePackage.getStylesheetsPath (/usr/share/atom/resources/app.asar/src/package.js:444:9)
ThemePackage.getStylesheetPaths (/usr/share/atom/resources/app.asar/src/package.js:455:32)
ThemePackage.loadStylesheets (/usr/share/atom/resources/app.asar/src/package.js:437:38)
<unknown> (/usr/share/atom/resources/app.asar/src/theme-package.js:47:19)

After the last update my theme doesn't change the colors, all stay white with any changes to color scheme monokai.

Pane::addItem(item, 0) is deprecated in favor of Pane::addItem(item, {index: 0})

Pane.addItem (C:\Users\NextDEV\AppData\Local\atom\app-1.14.3\resources\app.asar\src\pane.js:462:14)
Object.toggleView (D:\Users\NextDEV\.atom\packages\git-control\lib\git-control.coffee:50:21)
atom-workspace.<anonymous> (D:\Users\NextDEV\.atom\packages\git-control\lib\git-control.coffee:27:24)
CommandRegistry.handleCommandEvent (C:\Users\NextDEV\AppData\Local\atom\app-1.14.3\resources\app.asar\src\command-registry.js:259:29)
handleCommandEvent (C:\Users\NextDEV\AppData\Local\atom\app-1.14.3\resources\app.asar\src\command-registry.js:3:59)
CommandRegistry.dispatch (C:\Users\NextDEV\AppData\Local\atom\app-1.14.3\resources\app.asar\src\command-registry.js:160:19)

Hi, I am using seti ui with atom-monokai theme and the colorful display stopped working on all file types after updating from 0.10.4 to 0.10.7. This is happening on no matter what file language type selected.

All other themes work, even Atom Monokair Dark, but Atom Monokair does not.
Restarting atom doesn't work.
Overwrote my atom-monokai directory to a 0.10.4 version a colleague has on his system --this does not work.

I am using Windows 7 Professional.
Please advise on how to resolve this.

https://atom.io/packages/template-syntax

Other packages and the user's styles.less expect to be able to @import (reference) "syntax-variables"; and use the variables defined in that template. In a default setup it will work without, but a lot of customisations depend on this.