Hey,

Storage package does not have single file fetch
StorageObject xyz = bunnyCDNStorage.GetStorageObjectAsync(path);

And fullpath doesnt have base uri aswell.
https://cdn.bunny.test/test/file.jpg etc.

We are using BunnyCDN.Net.Storage as Data Manipulation. Can you merge "/api/purge" ?.

BunnyCDNStorage

• needs to implement IDisposable -> disposable pattern
• HttpClient inherits IDisposable from HttpMessageInvoker

HttpClient
public class HttpClient : System.Net.Http.HttpMessageInvoker

HttpMessageInvoker
public class HttpMessageInvoker : IDisposable

Seriously. Add logging.

Stop Using String Interpolation When Logging in .NET (Nick Chapsas)

High Performance Logging in .NET, the proper way (Nick Chapsas)

You're doing .NET logging wrong. Let's fix it. (Nick Chapsas)

Hi,
I've run into upload timeout for large files, because this timeout is hard coded into the https://github.com/BunnyWay/BunnyCDN.Net.Storage/blob/master/BunnyCDN.Net.Storage/BunnyCDNStorage.cs (Line: 40).

For my demands I cloned it, but I really think it's should be able to get configured in the libary.

Jan

Performance since Task is a class whereas ValueTask is a struct.

If the values are not going to be changed after creation, then using a ** record struct **, and potentially even ** readonly record struct ** if data is immutable. The reason for doing this is that Object.Equals compares the values of the record, and not the reference.

Records (C# reference) - value equality

Records: Immutability

Record Struct c# 10

BunnyCDNStorage should use zonename as object or enum

This is primitive obsession again.

Hi, would you mind adding a license? A MIT license or the sort would be great. Thanks

getting this error in visual studio when i try to run the storage manager
what could be the reason ?

public string ApiAccessKey { get; private set; }

• Change private to init
• also, why is it public? Can you remove the get

public string StorageZoneName { get; private set; }

• Change private to init
• also, why is it public? Can you remove the get

As you may already know, I'm trying to get the project fully unit-tested to ensure functionality.

CI using Travis: #8

I'd gladly create a travis-ci config for continuous delivery to nuget which would only require internal setup on the travis platform and be configured using environment variables.

e2e Testing

I would also like to add e2e unit-testing, would there be a possibility the project can have access to an unbilled e2e testing zone which we could use to ensure nothing in between broke?

Running this test before releasing it through the CI.would ensure no broken interfacing occurs in the released nuget package.
Only triggering it on tags would ensure there's no overuse or perhaps abuse of this zone.

Further feedback would be appreciated.

REASON: cleaner code and CopyToAsync performance

• https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/using-statement`

• https://docs.microsoft.com/en-us/dotnet/api/system.io.filestream.copytoasync?view=net-6.0

using (var bufferedStream = new BufferedStream(stream, 1024 * 64))
{
using (var fileStream = new FileStream(localFilePath, FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.ReadWrite, 1024 * 64))
{
bufferedStream.CopyTo(fileStream, 1024 * 64);
}
}

CHANGE TO

using var bufferedStream = new BufferedStream(stream, 1024 * 64);

using var fileStream = new FileStream(localFilePath, FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.ReadWrite, 1024 * 64);

await bufferedStream.CopyToAsync(fileStream, 1024 * 64);

public long Length => should be ulong
public int ServerId => uint
public long StorageZoneId => ulong

In general, you should not be doing primitive obsession and be using "value objects", ie. for path, zonename, etc

Treating Primitive Obsession with Value Objects (Nick Chapsas)

Will this project be released on NuGet by any chance?

String interpolation in Exceptions, and other areas, causes boxing which reduces performance.

UNLESS you are using c# 10

Stop Using String Interpolation When Logging in .NET (Nick Chapsas)

How c# 10 fixed string interpolation (Nick Chapsas)

The model contains a field called GUID, yet it is a string. This does not make sense.

• Same for UserId

Series: Using strongly-typed entity IDs to avoid primitive obsession

An introduction to strongly-typed entity IDs

The package is very nice and clear. But it needs a little more development;

Create Folder
Folder Name Update
Delete Folder

Issues like these need to be added.

In BunnyCDN.Net.Storage/BunnyCDNStorage.cs

In the Constructor of BunnyCDNStorage, it sets
_http.BaseAddress = new Uri("https://storage.bunnycdn.com/");
but when i use this. The messege says it is succeeded. But Actually it doesn't.
Upload file, messege 'complete', but no file on storage.

To fix this, I have to change to local uri "https://ny.storage.bunnycdn.com".

But i don't think this is what you intend to with this library.
I don't want hackky code. So please support this issue.

Fyi. I dev on Unity3D engine.