allow plugin scripts to be one file about peru HOT 5 CLOSED

I like the idea of specifying which scripts to invoke for each command in plugins.yaml. That eliminates the file ambiguity problem (extensions).

I'm not sure I agree that having some common code is annoying. I'm also not a huge fan of supporting varying ways to implement plugins (discrete commands or a single monolithic command). Switching on an environment variable is, in my opinion, at least as messy as just using tools designed for sharing code (e.g., import and source).

from peru.

For a thought in the completely opposite direction: What if we dispensed with the idea that plugin executables can be anything you want, and just required fetch.py and reup.py? You could still have those shell out to your custom executables if you want. Would that make the world meaningfully simpler?

from peru.

Of course whatever we do, it's going to be possible for users to turn that into any complicated plugin architecture they want. So I guess I'm just thinking about what a minimal useful plugin should look like in an ideal world. I find that I like

plugin.yaml
all_the_code.py

a lot better than

plugin.yaml
fetch.py
reup.py
shared.py

A big complicated plugin will tend towards lots of files either way, so I'm not really worried about that, but I wish we could at least allow the simplicity of the first example. Do you prefer the second?

from peru.

Thinking ahead about cleaning up the plugins, we could probably also get away with replacing most of our git() sort of helper methods with just check_call and check_output. At one point I think git() was a method on some more interesting object, but at this point it's a simple wrapper that's not doing much.

from peru.

https://phabricator.buildinspace.com/D97
https://phabricator.buildinspace.com/D98

from peru.