Comments (2)
That hidden abstraction layer is wonderful and one of the things I really like about the tool.
I think this check could be achieved through the use of which
, which the shutil
built-in has in shutil.which()
:
import shutil
def is_utility_available(cmd):
return shutil.which(cmd) is not None
def require_git():
if not is_utility_available("git"):
raise MissingUtilityException("git is unavailable. Please install git and re-run your command.")
Drop require_git()
early into any path that will need git and the user who forgot git will love the helpful error message instead of a FileNotFoundError or whatever is thrown with a long traceback.
from peru.
The main reason we haven't done something like this already is that peru tries pretty hard to keep itself to a single external invocation of the git
binary in the happy path. So like if you run peru sync
it does a tun a work and runs a bunch of commands. But if you run peru sync
again, it does very little. Currently only a single command to check the status of the tree. This is an imporant part of the "put peru sync
in your Makefile
or at the top of your Bash script and then forget about it" strategy.
So if checking for git
meant shelling out to git --version
or similar, that wouldn't be ideal. Is there another way of checking that you had in mind?
from peru.
Related Issues (20)
- Create a Contributing File HOT 1
- Allow curl module to be used as http module HOT 2
- Cannot download package possibly because of urllib defaults HOT 8
- Git 2.34 changed read-tree's handling of .gitignore files HOT 1
- Merging at the top level broken in git 2.36 HOT 2
- Feature Request: Add to .gitignore
- Doubt: is peru able to list the hashes for the git module? HOT 2
- Feature Request: Do not trade same files as merge conflict HOT 2
- on `reup` update rev with latest tag if rev is a tag HOT 1
- Why `If --file or --sync-dir is set, the other must also be set`?
- Release wheel package
- Import error when running from a venv HOT 2
- Import to home folder HOT 2
- Less verbose verbosity: progress output per percentage
- Named rules in sub-scoped peru files cause "Invalid name" errors at sync
- Issue with "Filename too long"
- Peru does not see changes when rev is a branch HOT 2
- Status of the project HOT 2
- Option to copy the full git clone, not just the files?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from peru.