Git Product home page Git Product logo

Comments (4)

olson-sean-k avatar olson-sean-k commented on June 25, 2024

I'm still a tad wary of this approach. If we export variables from peru, then won't we need to worry about cleaning that state (i.e., flush/write/unset all relevant variables) before each call to a plugin? It could be easy to miss something. Will this work equally well on Windows as it does on Linux?

I totally agree that validation really ought not live in plugins; they should trust that peru has correctly processed and scrubbed their parameters, and metadata in plugin.yaml should facilitate that.

from peru.

olson-sean-k avatar olson-sean-k commented on June 25, 2024

I guess subprocess accepts a dict of environment variables, so this should fine.

from peru.

oconnor663 avatar oconnor663 commented on June 25, 2024

Right. Also I think we want the subprocess to inherit random variables from the parent, in case there are global hacks ($LD_PRELOAD magic) that should apply to the plugin as well as the parent. But it might make sense to scrub the variables that we know are immediately relevant, like anything starting with our PERU_FIELD_ prefix or whatever it ends up being.

from peru.

olson-sean-k avatar olson-sean-k commented on June 25, 2024

Here's a diff for this.

from peru.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.