Comments (4)
I'm still a tad wary of this approach. If we export variables from peru, then won't we need to worry about cleaning that state (i.e., flush/write/unset all relevant variables) before each call to a plugin? It could be easy to miss something. Will this work equally well on Windows as it does on Linux?
I totally agree that validation really ought not live in plugins; they should trust that peru has correctly processed and scrubbed their parameters, and metadata in plugin.yaml
should facilitate that.
from peru.
I guess subprocess
accepts a dict of environment variables, so this should fine.
from peru.
Right. Also I think we want the subprocess to inherit random variables from the parent, in case there are global hacks ($LD_PRELOAD
magic) that should apply to the plugin as well as the parent. But it might make sense to scrub the variables that we know are immediately relevant, like anything starting with our PERU_FIELD_
prefix or whatever it ends up being.
from peru.
Here's a diff for this.
from peru.
Related Issues (20)
- Create a Contributing File HOT 1
- Allow curl module to be used as http module HOT 2
- Cannot download package possibly because of urllib defaults HOT 8
- Git 2.34 changed read-tree's handling of .gitignore files HOT 1
- Peru should check for the presence of external tools before invoking them HOT 2
- Merging at the top level broken in git 2.36 HOT 2
- Feature Request: Add to .gitignore
- Doubt: is peru able to list the hashes for the git module? HOT 2
- Feature Request: Do not trade same files as merge conflict HOT 2
- on `reup` update rev with latest tag if rev is a tag HOT 1
- Why `If --file or --sync-dir is set, the other must also be set`?
- Release wheel package
- Import error when running from a venv HOT 2
- Import to home folder HOT 2
- Less verbose verbosity: progress output per percentage
- Named rules in sub-scoped peru files cause "Invalid name" errors at sync
- Issue with "Filename too long"
- Peru does not see changes when rev is a branch HOT 2
- Status of the project HOT 2
- Option to copy the full git clone, not just the files?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from peru.