Git Product home page Git Product logo

Comments (5)

oconnor663 avatar oconnor663 commented on June 25, 2024

@olson-sean-k pointed out that "filter" is confusing. E.g. what does this mean:

filter: example.py

Is example.py supposed to in included, or excluded? Who knows. Instead, how about we call this "files"? That seems to work pretty well with all the different ways this attribute can be used:

files: example.py
files:
  - a.py
  - b.py
files: **/test*.py

Also, should we make sure it's an error if we end up matching no files? I feel like it should definitely be an error if you try to add a literal filename that's not there. Git might take care of that for us, actually.

from peru.

olson-sean-k avatar olson-sean-k commented on June 25, 2024

I think files is a good name for this. I also agree that matching no files should be an error.

from peru.

oconnor663 avatar oconnor663 commented on June 25, 2024

Ok I didn't think this through though: What if the argument to files: is a directory? Do you get everything in that directory? Maybe we should call it paths:? Or glob:? Edit: paths conflicts too closely with plugin fields like path in cp. Sticking with files.

from peru.

oconnor663 avatar oconnor663 commented on June 25, 2024

https://phabricator.buildinspace.com/D30

from peru.

oconnor663 avatar oconnor663 commented on June 25, 2024

675aac2

from peru.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.