Comments (5)
@olson-sean-k pointed out that "filter" is confusing. E.g. what does this mean:
filter: example.py
Is example.py
supposed to in included, or excluded? Who knows. Instead, how about we call this "files"? That seems to work pretty well with all the different ways this attribute can be used:
files: example.py
files:
- a.py
- b.py
files: **/test*.py
Also, should we make sure it's an error if we end up matching no files? I feel like it should definitely be an error if you try to add a literal filename that's not there. Git might take care of that for us, actually.
from peru.
I think files
is a good name for this. I also agree that matching no files should be an error.
from peru.
Ok I didn't think this through though: What if the argument to files:
is a directory? Do you get everything in that directory? Maybe we should call it Edit: paths:
? Or glob:
?paths
conflicts too closely with plugin fields like path
in cp
. Sticking with files
.
from peru.
https://phabricator.buildinspace.com/D30
from peru.
from peru.
Related Issues (20)
- Create a Contributing File HOT 1
- Allow curl module to be used as http module HOT 2
- Cannot download package possibly because of urllib defaults HOT 8
- Git 2.34 changed read-tree's handling of .gitignore files HOT 1
- Peru should check for the presence of external tools before invoking them HOT 2
- Merging at the top level broken in git 2.36 HOT 2
- Feature Request: Add to .gitignore
- Doubt: is peru able to list the hashes for the git module? HOT 2
- Feature Request: Do not trade same files as merge conflict HOT 2
- on `reup` update rev with latest tag if rev is a tag HOT 1
- Why `If --file or --sync-dir is set, the other must also be set`?
- Release wheel package
- Import error when running from a venv HOT 2
- Import to home folder HOT 2
- Less verbose verbosity: progress output per percentage
- Named rules in sub-scoped peru files cause "Invalid name" errors at sync
- Issue with "Filename too long"
- Peru does not see changes when rev is a branch HOT 2
- Status of the project HOT 2
- Option to copy the full git clone, not just the files?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from peru.