Change API call signatures to use ErrorType instead of NSError about xcodeserversdk HOT 4 OPEN

Can you provide an example? AFAIK, all our APIs are asynchronous, so the callback block is called much later after the call of the API method. Throw only works with synchronous calls.

What we could do is change the signature from NSError to ErrorType. That would be a good improvement, because it would allow for error enum types.

from xcodeserversdk.

Right, async... And I'm back home 😉 But we have more methods which may be considered this way eg. createRequest() returns NSMutableRequest?.

Anyway, ErrorTypes sounds great!

from xcodeserversdk.

Yup, createRequest() would be a good candidate for throwing.

from xcodeserversdk.

Action: look into changing the error type in API call block callbacks from NSError to ErrorType.

from xcodeserversdk.