Comments (6)
You rather want it to return some kind of completion
or simply throw
?
from xcodeserversdk.
I think if we want to fail bot creation process we should stick with throw
😉 I'll try to do something with this issue today...
from xcodeserversdk.
It's an asynchronous process so I don't think throw
will work. Just
creating an error and completing should be enough.
On Thu, Oct 1, 2015 at 9:53 AM Mateusz Zając [email protected]
wrote:
I think if we want to fail bot creation process we should stick with throw
😉 I'll try to do something with this issue today...—
Reply to this email directly or view it on GitHub
#114 (comment)
.
from xcodeserversdk.
private func replacePlaceholderPlatformInBot(bot: Bot, platforms: [DevicePlatform])
is the method in which the fatalError
s are called... Looks to me like it's totally synchronous. The bot creation isn't synchronous... Anyway, you suggest returning of the optional ErrorType
from this method? Seems legit 😉
from xcodeserversdk.
Oh right, I was talking about the big picture of the whole process. Makes
perfect sense here to throw, sorry. What I meant is that that error should
then be fed into the failing completion block.
On Thu, Oct 1, 2015 at 10:02 AM Mateusz Zając [email protected]
wrote:
private func replacePlaceholderPlatformInBot(bot: Bot, platforms:
[DevicePlatform]) is the method in which the fatalErrors are called...
Looks to me like it's totally synchronous. The bot creation isn't
synchronous... Anyway, you suggest returning of the optional ErrorType
from this method? Seems legit 😉—
Reply to this email directly or view it on GitHub
#114 (comment)
.
from xcodeserversdk.
Communication is always an issue in my case 😜 Great that we're now on the same tracks!
from xcodeserversdk.
Related Issues (20)
- Provide RAC extensions (as a subspec) HOT 2
- Use Nimble for test matchers HOT 4
- Add support for live updates from XCS HOT 1
- Wait for integration results HOT 2
- Add platforms for tvOS and tvOS simulator HOT 1
- Rename dictionarify to jsonify to be consistent with BuildaUtils
- Review & adapt to the new XCS API Docs HOT 2
- Release a spec with tvOS support HOT 1
- XcodeServerProxy (proxy, load balancer) HOT 4
- Has API changed with latest OS X Server update? HOT 8
- Call to server.getIntegrations fails with 400 Error HOT 4
- Incompatible with Xcode 7.3 beta HOT 4
- Build a API tester to run on every new release
- Cancel API not working HOT 3
- Not compiling in Swift 2.3 HOT 2
- bot creation HOT 1
- Include repository fingerprint to make adjusting bots easier
- Re-record test cassettes with Xcode 7 Beta 6 changes HOT 1
- Don't send `rev` when deleting a Bot
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xcodeserversdk.