Git Product home page Git Product logo

Comments (6)

cojoj avatar cojoj commented on July 17, 2024

You rather want it to return some kind of completion or simply throw?

from xcodeserversdk.

cojoj avatar cojoj commented on July 17, 2024

I think if we want to fail bot creation process we should stick with throw 😉 I'll try to do something with this issue today...

from xcodeserversdk.

czechboy0 avatar czechboy0 commented on July 17, 2024

It's an asynchronous process so I don't think throw will work. Just
creating an error and completing should be enough.
On Thu, Oct 1, 2015 at 9:53 AM Mateusz Zając [email protected]
wrote:

I think if we want to fail bot creation process we should stick with throw
😉 I'll try to do something with this issue today...


Reply to this email directly or view it on GitHub
#114 (comment)
.

from xcodeserversdk.

cojoj avatar cojoj commented on July 17, 2024

private func replacePlaceholderPlatformInBot(bot: Bot, platforms: [DevicePlatform]) is the method in which the fatalErrors are called... Looks to me like it's totally synchronous. The bot creation isn't synchronous... Anyway, you suggest returning of the optional ErrorType from this method? Seems legit 😉

from xcodeserversdk.

czechboy0 avatar czechboy0 commented on July 17, 2024

Oh right, I was talking about the big picture of the whole process. Makes
perfect sense here to throw, sorry. What I meant is that that error should
then be fed into the failing completion block.
On Thu, Oct 1, 2015 at 10:02 AM Mateusz Zając [email protected]
wrote:

private func replacePlaceholderPlatformInBot(bot: Bot, platforms:
[DevicePlatform]) is the method in which the fatalErrors are called...
Looks to me like it's totally synchronous. The bot creation isn't
synchronous... Anyway, you suggest returning of the optional ErrorType
from this method? Seems legit 😉


Reply to this email directly or view it on GitHub
#114 (comment)
.

from xcodeserversdk.

cojoj avatar cojoj commented on July 17, 2024

Communication is always an issue in my case 😜 Great that we're now on the same tracks!

from xcodeserversdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.