bsantosh909 / croyale Goto Github PK

Currently the keys, Exclude and other query parameters work even if they are not array. There should be an better check to see if its actually an array.

Implement pagination for the possible endpoints (i.e. the endpoints that return an array) as described here here

Do not Enough
/players?/:Tag/battles?

At the moment it is impossible to get the number of matches.
It will be great if you add it.

Implement caching so that unnecassary request wont be made to the API for the time being.

How can I get clan chat?

Hi, it would be great. If there is an opportunity to get ratelimit. Here so for example. Where var ratetime is the client's object.
https://gist.github.com/Friday14/d7733cac6a8b2cba8ef0bc7a9a65a369

(Issue title pretty self explanatory)

Expected Result: Upon getting clanChest stats of invalid clan tag, an Improper request error from wrapper.

Actual Result: 400 bad request error from the API itself.

So the issue seems to be that the wrapper isnt catching invalid tags, leading to something returning an unintelligible mess that messes with other error checking logic. TypeError: err.includes is not a function is what shows up when I run a getplayer on 3333

Offending line on: https://github.com/TheLearneer/croyale/blob/master/src/client.js line 85.

When submitting a tag that is not registered to a player, it returns an error containing a 404 in a string. However, when submitting nothing it returns an error in a object type, which leads to impossibility in checking which it was on data returning.

These are the functionality (endpoints) missing in the wrapper at current:

• Clan Search
• 1K tournaments
• In preparation tournaments
• Full tournaments
• Joinable tournaments
• Tournament search
• Popular decks