Cubemap brighter "washed out" compared to equirectangular (a-sky) about aframe-cubemap-component HOT 11 CLOSED

I tried that in a local copy and yes that "fixes" the issue (now the cubemap version looks the same as the equirectangular a-sky version). I think the question now is if sRGBEncoding should be default, up to you.

from aframe-cubemap-component.

Those discussions make it sound like texture.encoding = THREE.sRGBEncoding; should be the default, but when I tried it with the Yokohama example the resulting cubemap was darker than the original image:

Left is the original image, right is the rendered cubemap.

from aframe-cubemap-component.

For comparison, here is the current code (without texture.encoding = THREE.sRGBEncoding;).

Left is the original image, right is the rendered cubemap.

from aframe-cubemap-component.

I can certainly make texture encoding a property though.

from aframe-cubemap-component.

Good points all around, yes a property probably makes the most sense

from aframe-cubemap-component.

Did some more reading into this and found A-Frame's renderer has a colorManagement property that balances the darkness brought by texture.encoding = THREE.sRGBEncoding;.

<a-scene renderer="colorManagement: true">
  <a-entity cubemap="folder: /assets/Yokohama3/"></a-entity>
</a-scene>

I still think making texture encoding a property is the way to go, but maybe A-Frame will make colorManagement: true the default some day.

from aframe-cubemap-component.

Looks good! Thanks for digging in to that, and your new example showing what happens with colorManagement: true on the scene while using sRGBEncoding is helpful and accurate as far as I know.

In fact, it appears that when colorManagement: true, the A-Frame core material handlers use a helper applyColorCorrection function to set textures to sRGBEncoding, like in this example.

from aframe-cubemap-component.

In fact, it appears that when colorManagement: true, the A-Frame core material handlers use a helper applyColorCorrection function to set textures to sRGBEncoding, like in this example.

Oh interesting! Instead of an encoding property, we could retrieve the renderer system and apply color correction automatically just like the core library. I think this would actually be better!

Thanks for those links!

from aframe-cubemap-component.

@kfarr thoughts on this MR?

from aframe-cubemap-component.

Yes this looks great! I didn't test it but the logic seems right. I can test a little later or after you commit those changes.

from aframe-cubemap-component.

Yes this looks great! I didn't test it but the logic seems right. I can test a little later or after you commit those changes.

Cool.

I'll merge it in--we can patch it later if you find it's not working correctly.

from aframe-cubemap-component.