brunty / cigar Goto Github PK

Allow an --auth (-a) option to pass an authorisation header string in.

Not sure if it's needed to use something like symfony/console etc - it feels like an unnecessary dependency, despite the niceness for options / output etc.

Cigar is a basic tool and I'm not sure it needs it.

It's a good practice to link to similar tools in a README file. Can you add this one? It seems it can do same as cigar. https://github.com/blackfireio/player

Having both those time outs supported would be great. Running into an issue where it continues to wait for a requests that for some reason never completes

Fatal error: Uncaught Error: Class 'Brunty\Cigar\Outputter' not found

When running inside another project:

composer require --dev brunty/cigar
vendor/bin/cigar

I'm toying with the idea to run cigar against production as an extra safe guard the application is still functioning as it should. Are you open to a JSON output writer?

Nice idea! Might be nice to optionally check for content (regex is probably best used here for flexibility) when making the request.

having a phar file would be awesome

When running inside a project, it can't find the autoload file as it's looking in:

require __DIR__ . '/../vendor/autoload.php';

And when the file is required, it's in vendor/bin

Follow up of #32 (comment), adding such test would require a host that can wait X seconds before accepting the connection

We currently still have projects which use PHP 7.0 so I wonder if you would be willing to support that PHP version too.

I am aware that PHP 7.0 is EOL at the end of this year but sometimes the choice is not ours. I'd still love to integrate cigar in these projects however.

Badly formatted .cigar files cause errors. Fix.

It's not used / needed

Similar to https://github.com/symm/vape it should be possible to pass the base URL for smoke tests as CLI argument instead of hardcoding it in the .cigar.json.

This is essential for running the same batch of checks against multiple environments of the same project, e.g. staging and production.

Currently one can work around this with multiple files named after the environments and passing them to the CLI accordingly but this can quickly become a hassle to manage, especially if the files are not properly kept in sync.

Add docs on how to run tests and where they're located

Link to https://kahlan.github.io/docs/
Tests in spec/
Run tests with vendor/bin/kahlan --reporter=verbose

The content check is really useful, but I would love to see a check for the Content-Type header.

In some cases it is required to ignore an "incorrect" SSL certificate. For example a self-signed certificate.

This can be done by disabling peer verification:
https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html

curl_setopt($channel, CURLOPT_SSL_VERIFYPEER, 0);

It seems that currently this kind of "overall" configuration is not supported? I could imagine a similar feature request for support of HTTP Basic Authentication...