brunnerlivio / deprecated-pokemongo-game-master Goto Github PK

Not sure it is a bug or as it is just provided by the game itself. But the following charged / cinematic moves are double in Mew

• Psychic (100)
• Ancient Power (70)
• Dragon Claw (50)
• Psyshock (65)
• Ice Beam (90)
• Blizzard (130)
• Hyper Beam (150)
• Solar Beam (180)
• Thunderbolt (80)
• Thunder (100)

The following values in the pokemonSettings.encounter properties changed for a few Pokémon a couple days ago.

Original post

To save some time and prevent issues, travis tests should be considered.

Testcase:

Check if latest-version.txt has the latest version number from the versions/-folder written.
For example if the structure looks like:

    ├── latest-version.txt
    ├── 0.57.1
    │   ├── GAME_MASTER.json
    │   └── GAME_MASTER.protobuf
    ├── 0.57.2
    │   ├── GAME_MASTER.json
    │   └── GAME_MASTER.protobuf
    └── latest
        ├── GAME_MASTER.json
        └── GAME_MASTER.protobuf

latest-version.txt should have written 0.57.2

I suggest NodeJS to write the test using Mocha. There's a package, called semver, which helps to parse and sort the versions. But I'm open for another languages, if they provide more advantages.

It would be nice to also include the pokedex numbers. I.e. Bulbasaur 1, Ivysaur 2, etc.

The instructions to add a new or older version is quite complicated. It would be much nicer if we have a script, which can be parameterized to do your work.

Example for adding latest version

$ ./pokemongo-game-master/bin/add-version.sh -f ./newversion.protobuf -v "0.83.2-1" --latest

Example for adding specific version

$ ./pokemongo-game-master/bin/add-version.sh -f ./newversion.protobuf -v "0.83.2-1"

It should first generate the JSON file, then create the needed folders ("latest" and "0.83.2-1" folder), copy the files to the correct folder and then update latest-version.txt

I'm using this repository in a tool of my own to extract metadata about the game. My next goal is to get legacy moves, which to me it seems like the best course of action is to incrementally build via all known GAME_MASTER files. This repo currently only goes back to Feb 2017, which is pretty extensive, but is still missing 6-7 months of other versions.

If anyone knows of a way to get at the older versions, I'm more than happy to do the manual work required to contribute them here. However, I'm afraid that getting the older versions after-the-fact is not possible, is that in fact the case? (or is there some other archive of files that someone else has been maintaining longer than this one)

It needs to work on my windows machine :)

It should not be hard to combine the build script and maven call into a single docker command

I was working on adding the latest version of the GAME_MASTER (v0.97.2) so I could use some newer metadata downstream (eg: Frenzy Plant). I forked this repo and attempted to run ./bin/add-version.sh for myself so I could PR the updated file back.

Unfortunately, it didn't work and I'm unable to debug it. Here are the logs from when I ran the script:

[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building PokeBattler Fight 2.22.0
[INFO] ------------------------------------------------------------------------
Downloading: https://raw.github.com/celandro/pogoprotos-java/mvn-repo/com/pokebattler/pogoprotos/2.22.0/pogoprotos-2.22.0.pom
Downloading: https://repo.maven.apache.org/maven2/com/pokebattler/pogoprotos/2.22.0/pogoprotos-2.22.0.pom
[WARNING] The POM for com.pokebattler:pogoprotos:jar:2.22.0 is missing, no dependency information available
Downloading: https://raw.github.com/celandro/pogoprotos-java/mvn-repo/com/pokebattler/pogoprotos/2.22.0/pogoprotos-2.22.0.jar
Downloading: https://repo.maven.apache.org/maven2/com/pokebattler/pogoprotos/2.22.0/pogoprotos-2.22.0.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.793 s
[INFO] Finished at: 2018-04-01T17:04:31+00:00
[INFO] Final Memory: 11M/153M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project pokemongo-game-master: Could not resolve dependencies for project com.pokebattler:pokemongo-game-master:jar:2.22.0: Could not find artifact com.pokebattler:pogoprotos:jar:2.22.0 in pogoprotos-java-mvn-repo (https://raw.github.com/celandro/pogoprotos-java/mvn-repo/) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException

It looks like it has to do with the pokebattler dependency. I'm not a Java dev at all, so I'm unsure how to proceed. If it's easier, I can send my GAME_MASTER.protobuf via PR so it can be added.

Thanks for this repo! It has made my own project a lot easier. :)

Anyone know what the array order is for the attackScalar type values?

I see just an array of values, don't know where to ref the key though.

This repo has been priceless to me so I felt I had to at least offer to share this, it's your game master File with all legacy moves added.

http://pogonium.com/GAME_MASTER.json

Today @AeonLucid declared his POGOProtos repository as "no longer maintained". This is unfortunate for depending developers. Since a shift of main contributor is always a tricky situation, I suggest we move the repository "pokemongo-game-master" and "pokemgo-json-pokedex" repo in an organization, so if I do not want to maintain those repository in the future, it would not change the repository address.

I would also highly welcome @Furtif to join this repository with this POGOProtos repository.

We can move the repository if the main contributors agree with this. @celandro @dandesousa

I have created an organization in advance: https://github.com/pokemongo-proto

Is possible create a raw proto style this https://github.com/Furtif/POGOProtos/blob/master/base/v0.79.2.proto for lasted versions? thanks

I'm not a Java expert, but is it possible to create a Docker image with all its needed dependencies?
So a user, which does not know Java can simply build the container and generate a new JSON.

This would be really useful for lazy people like me, who don't want to install all the dependencies, just to generate the json file

Update files to 0.61.0

Any chance of getting the legacy moves added?

One can dream right. Thanks anyway, this repo rocks either way.

Update files to 0.59.1

All Gen 3 Pokemon have quick move Splash and charged move Struggle
Is this a compile error of is it just the data provided by the game?

https://github.com/BrunnerLivio/pokemongo-game-master/tree/master/versions/0.83.3

Edit: charged move is struggle for every gen 3 pokemon

iirc, there is a section of the .proto dedicated to lists of constants, such as:

POKEMON_TYPE_NORMAL: 1

Downstream, it's impossible to match the numbers in typeEffective.attackScalar with the corresponding type without the original ID numbers.

It would be great to include those enums alongside itemTemplates.