Hi Hermann,

me again. I also took a short view to the build process. And I found this:

On the one hand, you suppress linking using the -c flag. And on the other hand you pass the LDFLAGS. Is it a bug or does it make sense? Please apologize my question, but I'm still having a real struggle with linking at all.

Viele Grüße
Sven

When building mamba 2.5 with libxputty at 62ec1cf and with gcc 12.3 (with -Werror=format-security) and glibc 2.38, the build fails like this:

../xputty/xfilepicker.c:225:5: error: format not a string literal and no format arguments [-Werror=format-security]
  225 |     asprintf(&filepicker->path, path);
      |     ^~~~~~~~

The full log is available at https://hydra.nixos.org/build/230518081.

I guess this popped up now because asprintf and friends is in glibc 2.38 available by default and because of that, the format warning is actually triggered on said function.

Anyways, while it's indeed a workaround to switch to -Wno-error, I think it's still reasonable to fix that warning properly in the code.

Hi Hermann,

finally I found some time (which I don't have got ;-)) to take a closer look to libxputty. Some smart solutions and it looks really efficient for low complexity UIs. And I'm going to use it in two of my next tutorial videos (in April 2023).

However, I initially struggled to load a .png image file (I mean the file, not converted to .c and hard compiled) and to visualize it. You created widget_get_png (Widget_t *w, const unsigned char* name), which looks like doing this job. However, it expects a data stream for name and not the filename. A bit confusing ;-). And there are a lot of similar methods in xpngloader.h, but all expect img data for name instead of a filename.

On the other hand, there is a widget_get_svg (Widget_t *w, const char* name) in xsvgloader.h doing exactly what I expect. name is the filename there.

Therefore my feature request: Add a png loading function from a .png file. Like widget_get_png_from_file (Widget_t *w, const char* name) to not break the API. And it would be nice to rename the parameter name for the png stream-accepting widget_get... functions to data or stream or ... . Just for more clearness.

Viele Grüße
Sven