bronsonquick / flair Goto Github PK

Add support for breadcrumbs. See if we can filter Yoasts Breadcrumbs:

http://foundation.zurb.com/docs/components/breadcrumbs.html

• Interchange
• Top Bar
• Magellan
• Orbit
• Clearing
• Abide
• Reveal
• Alert
• Tooltip
• Joyride

Some of the font colors and editor specific files are stored in settings and typography partials.

If these add too much bulk (settings in particular) should colors be repeated in variables instead of settings.scss (the foundation way)?

It's probably best to take them from:

• https://github.com/sennza/Sennza/blob/master/themes/sennzav3/inc/template-tags.php
• https://github.com/sennza/Sennza/blob/master/themes/sennzav3/inc/extras.php

But cross check with the latest from _s:

• https://github.com/Automattic/_s/blob/master/inc/template-tags.php
• https://github.com/Automattic/_s/blob/master/inc/extras.php

Noticed this is missed in .gitignore.

Cherry-pick a filter from the Pico framework to wrap videos with a div.flex-video for Foundation's Flex vids: http://foundation.zurb.com/docs/components/flex_video.html

Add in some notes about:

• add_theme_support for Foundation scripts
• Why style.css is just a header
• Folder structure

Sass files exist, but are not linked to the app.scss SASS file:

_small-up.scss
_medium-up.scss
_large-up.scss
_xlarge-up.scss
_xxlarge-up.scss

also; _xxlarge.scss is missing from app.scss

When a nav menu isn't defined (i.e. after importing the Theme Unit Test data) our "menus" look broken. e.g.

Let's see if we can filter wp_page_menu to add Foundation menu CSS classes like: https://github.com/sennza/Flair/blob/master/themes/flair/inc/foundation-filters.php#L4

Not sure if this is intentionally excluded to save potential confusion when both pages.php and front-page.php are included in starter themes.. but thought I would drop a mention.

https://github.com/sennza/Flair/blob/master/themes/flair/functions.php#L96

We should refer to this as a 'Main Widget Area'.

Automattic/_s#419

The Gravity Forms filters need to be reworked as they don't work on complex forms

'Main widget area' is currently used as a global sidebar widget for pages and posts. Jetpacks widget visibility has its limitations and separate content for these is consistent in all our designs so it makes sense to have these as 2 default widget areas.

https://github.com/sennza/Flair/blob/master/functions.php#L97

It's best to make sure we have an easy way to alter the page, content and sidebar column widths used in the theme: e.g.
https://github.com/sennza/FoundationFramework/blob/master/themes/flair/sidebar.php#L11

Add something similar to what I did on the Sennza site but make it more robust.

http://make.wordpress.org/core/2014/04/15/html5-galleries-captions-in-wordpress-3-9/

If you "forget" to do the initial setup steps of npm install and bower install, running grunt gives you a "Fatal error: Unable to find local Grunt" error. This is a wee bit cryptic, and it'd be nice to catch that and fix it.

It looks like we should probably drop the Gravity Form filters and remove Foundations Form styling

flair_nav_menu_item_parent_classing() querying database multiple times when adding a 'parent' class to menu.

👍

For some reason I forgot to add single.php

Add theme support for the follow as well:

• Equalizer
• Accordions
• Tabs

Let's make sure our videos responsive from the start: http://foundation.zurb.com/docs/components/flex_video.html

Filter wp_pagenavi to produce the markup Foundation requires http://foundation.zurb.com/docs/components/pagination.html

Something like https://github.com/sennza/Sennza/blob/master/themes/sennzav3/sass/editor-style.scss will do

We should include the following as well:

1. Small Up _small-up.scss
2. Medium Up _medium-up.scss
3. Large Up _large-up.scss
4. XLarge Up _xlarge-up.scss
5. XXLarge Up _xxlarge-up.scss

http://foundation.zurb.com/docs/components/topbar.html#positioning-the-bar

We need a 404 page. e.g. http://puu.sh/7WuZp.png

Cherry Pick from https://github.com/sennza/Sennza/tree/master/themes/sennzav3/sass

2, 3 and 4 columns will do to start with

Knowing that '_s as a starter theme' sentiment from Automattic, is it possible to parent/child theme Flair?

Possible benefits:

• Update and enhance Flair parent from within projects (by updating parent theme and sending Pull Request)
• Add new features + support to themes as they are discovered and developed
• Set a good precedence for parent/child theme support with Picothemes

Just putting the question out there - even though everything I read says thats not 'how its meant to work', contradicts the 'WordPress way' of child theming.

e.g. https://gist.githubusercontent.com/BronsonQuick/2692275/raw/74d18293b5af34c80e90006b36c69dc0934aaf8f/link_inside_archive_and_category_widget.php

Sexy new HTML5 gallery in WP currently has no default styling.