broesler / jupyter-vim Goto Github PK

I'm running nvim on Ubuntu 20.04, when I run jupyter qtconsole, the console opens up but I want to change the colorscheme which isn't happening and I'm getting the following error in the terminal

TypeError: <lambda>() missing 1 required positional argument: 'v'

Python version 3.9.5

https://github.com/broesler/jupyter-vim/blob/ca4296f/pythonx/jupyter_vim.py#L273 is
msgs = kc.iopub_channel.get_msgs(block=False)

This didn't work for me. According to https://github.com/jupyter/jupyter_client/blob/master/jupyter_client/blocking/channels.py#L59 get_msgs doesn't take any parameters (aside from self), and setting block to False is unnecessary since it only returns msgs that are currently ready.

block=True is a valid parameter to get_msg (singular) and it's what get_msgs uses internally.

This one might be a bit controversial: Given that you need configuration in order to see output in jupyter console/qtconsole, I'd recommend making g:jupyter_monitor_console=1 the default. This would make jupyter-vim have a less steep learning curve. It's a lot easier to disable the console once you have the tool working than to be running the tool and be frustrated that you don't see anything happening. We can even output a message to the console explaining how to disable it. Thoughts?

In particular, I found the section on "First, we need to configure the jupyter console and qtconsole clients to display output from other clients" useful and I struggled to figure out how to do this. Later, I discovered that it was already documented in wmvanvliet's version.

This is sorta implicitly documented in https://github.com/broesler/jupyter-vim/blob/master/doc/jupyter-vim.txt (in the "JUPYTER-VIM VS. VIM-IPYTHON" section), but I think it should be much more prominent.

Connecting is a bit brittle. I'd like to add some output, even if verbose is turned off, to help inform the user some details about the connection problem.

This trips up help doc generation. The second instance should be jupyter-vim-introduction

At some point, I forked from ivanov/vim-ipython, then this repo was forked from me. You cleaned everything up, doing such a good job that my branch now tracks this repo. People have raised issues and PRs on both my repo and this one. It's a bit of a mess.

How do you feel about creating a "jupyter-vim" github organization and work together in one repo?

Vundle is very popular these days, so I think we should document it as an option. Recent versions of vim make manual installation a breeze, so I think we should document that as an option too. (See https://shapeshed.com/vim-packages/ for details)

My Jupyter installation seems to put the connection json files in ~/Library/Jupyter/runtime/. I'm on Mac, so perhaps that explains the difference? Anyway, I'd like to make jupyter-vim check that path, in the event that the connection json files aren't found in the current directory. I notice that other places do it like this: https://github.com/jupyter/jupyter_client/blob/34f96d7293e55364690c1dbdff8647ffb84854a3/jupyter_client/consoleapp.py#L168 so I think something like that is the right fix.