When you click on a report row it will trigger the "module info" popover to open.

<a target="_blank" rel="noopener noreferrer nofollow" href="https://user-images.github

Fix at <a class="issue-link js-issue-link" data-error-text="Failed to load title" data

When clicking on a report row popover opens. Can't be dismisssed about silverstripe-maintenance HOT 6 CLOSED

bringyourownideas commented on May 24, 2024

When clicking on a report row popover opens. Can't be dismisssed

from silverstripe-maintenance.

Comments (6)

NightJar commented on May 24, 2024

from silverstripe-maintenance.

ScopeyNZ commented on May 24, 2024

from silverstripe-maintenance.

raissanorth commented on May 24, 2024

Clicking the row when the popover is open first triggers the popover's native closing mechanism, then the click on the row is registered and opens it again; see below for reference

silverstripe-maintenance/client/src/legacy/entwine/SiteSummary.js

Lines 25 to 36 in 4f95fda

 $('.site-summary .ss-gridfield-item').entwine({ 

 /** 

  * When you click on a table row (not a button in the table row), trigger the button 

  * to be clicked. 

  */ 

 onclick(e) { 

 if ($(e.target).is('button')) { 

 return; 

 } 

 this.find('.package-summary__module-info-trigger').click(); 

 } 

 });

from silverstripe-maintenance.

robbieaverill commented on May 24, 2024

Oh cool, we need to adjust that logic again 😆

from silverstripe-maintenance.

robbieaverill commented on May 24, 2024

I guess in that same logic we could add a data attribute to the row like data-popover-opened="1" then check for and remove that when this logic is re-triggered - use that to control whether to auto-click the popover's trigger inside the table row in some cases but not always

from silverstripe-maintenance.

robbieaverill commented on May 24, 2024

Fix at #117

from silverstripe-maintenance.

When clicking on a report row popover opens. Can't be dismisssed about silverstripe-maintenance HOT 6 CLOSED

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	$('.site-summary .ss-gridfield-item').entwine({
	/**
	* When you click on a table row (not a button in the table row), trigger the button
	* to be clicked.
	*/
	onclick(e) {
	if ($(e.target).is('button')) {
	return;
	}
	this.find('.package-summary__module-info-trigger').click();
	}
	});