Can't use module on CWP platform about silverstripe-maintenance HOT 14 CLOSED

I'd like to also point out that while we've achieved resolution in the context of which we are testing, I think this issue spans wider than just CWP (or the recipe of such at least), indicated in the fact that it also affected SSP - and while it works again now, it's because we're testing it in the context of a CWP recipe.

The fix:
https://github.com/silverstripe/cwp/blob/3ad235e1286939a5291a911c602ca42907b1746c/src/Extensions/MaintenanceProxyExtension.php#L29
Resides in cwp/cwp (where this extension also addresses platform specific proxy issues, which is a good thing).

Meaning anyone not using CWP (at least the module, but in the broader sense the platform as a whole) will still be affected by this exception any time they attempt to retrieve the task list (or run the task itself) from a user that does not have these environment variables set.

However if I were betting inclined, I'd wager that this will affect any web server that runs as it's own user - typically a non-login user meaning an absence any profile setup files... and in many a case it's a system user (UID lower than 1000) which can also mean there is no $HOME set either.

Exemplified in the virtual environment I was finally able to recreate this issue; there was nothing special about it's setup that I would consider unusual.

At this point I'd like to suggest moving this composer environment variable check (i.e. not the proxy ones from the same class) to that in which the exception manifests - bringyourownideas/silverstripe-composer-update-checker.

from silverstripe-maintenance.

Sure, I'll do that

from silverstripe-maintenance.

Falsy, forgot to deploy the updated 1.9 CWP code 🤦‍♂️

from silverstripe-maintenance.

Give it a god, but not sure if this will work as this would rely on putenv() to pass the variable to composer, which seems to fail intermittently.

from silverstripe-maintenance.

Is this issue relevant to SSP as well?

from silverstripe-maintenance.

Yep, just tested

from silverstripe-maintenance.

Environment::setEnv/putEnv doesn't carry through, but putenv works

from silverstripe-maintenance.

Ok, now hitting a blocker with the CWP proxy (related: silverstripe/silverstripe-cms#2168).

Will need to see if we can inject this config somehow

from silverstripe-maintenance.

Nice work!

from silverstripe-maintenance.

Need to backport change for the CWP 1.9 recipe too

from silverstripe-maintenance.

Ideal, all done! Thanks @robbieaverill

from silverstripe-maintenance.

I've merged all the branches up.

from silverstripe-maintenance.

Tested CWP 1.9 and 2.1 on CWP platform, all good!

from silverstripe-maintenance.

Whoops, the task doesn't run in 1.9 on CWP

from silverstripe-maintenance.