Git Product home page Git Product logo

bem's Issues

using nesting for blocks an modifiers

Please use nesting for blocks.
Example:

.c-header {
  ...

  &__title {
    color: #ffffff;
  }

  &__subtitle {
    color: #b6cece;
  }

  &__title--red {
    color: #ffffff;
  }
}

именование классов

имя класса purple - это хорошо когда не BEM. В данном случае цвет выступает как модификатор класса (М).
пример: c-cards--purple или c-cards__img--purple

Префиксы

Префиксы webkit-column-count и остальные лучше добавлять через сборщики. Для этого есть специальные пакеты.

форматирование стилей

  • пробел между именем класса и скобкой;
  • пробел между свойством и значением;
  • отступ между классами

пример:

.c-switcher {
    background-color: #27212b;
    display: flex;
    width: 100%;
    justify-content: space-between;

  &__text {
    font-size: 0.85rem;
    color: #95859f;
    padding: 2rem;
  }

  &__arrow {
    background-color: #bc3184;
    padding: 2rem;
  }
}

README.md

отсутсвует файл с описанием задания и как запускать проект.
создай в корне проекта README.md и добавь в него описание

Commits format

Please use next format for commits:
Task: description

Example: BEM: update main heading

using only class for styling in BEM

Please use for style only class.

Bad example:

.c-navbar__link {
    list-style: none;

    a {
        color: #ffffff;
    }
}

Good example:

.c-navbar__link {
    list-style: none;

    .c-navbar__link-item {
        color: #ffffff;
    }
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.