bricestacey / gift_manager Goto Github PK

root_path routes to /?locale=en. By default, this should route to /. When a locale is set, it should route to /:locale.

ActionView::Template::Error (can't convert nil into String):
67: %p.thumbnail
68: %b Thumbnail:
69: %br
70: = image_tag(@book.thumbnail)
app/views/books/show.html.haml:70:in _app_views_books_show_html_haml__212017316_85145680_91529092' app/controllers/books_controller.rb:14:inshow'

The scope buttons in the index views should be refactored as helpers

e.g. this needs to go away

= link_to "Active (#{Bin.active.count})", bins_path(:scope => 'active'), :class => "button pill#{(params[:scope] == 'active' or params[:scope].nil?) ? ' primary' : ''}"
= link_to "Inactive (#{Bin.inactive.count})", bins_path(:scope => 'inactive'), :class => "button pill#{(params[:scope] == 'inactive') ? ' primary' : ''}"

and be more like

= facet_to :active
= facet_to :inactive

or maybe

= facets_to(:active, :inactive)

A user doesn't know how to move an item to a different bin.

This can be accomplished by going to "Books", finding the item, editing it, and you can select from the drop down menu a list of bins. When you are working under a particular bin, that option is not provided.

Must come up with a better UX for this.

Users should be able to select multiple books and perform an action on the set.

• rename .find_by_isbn to .attributes_for_isbn
• extract methods .get_bib_data and .get_location_data

Holdings information looks something like this

.panel-contents
  .span-4 Held Local
  .span-13.last= (@book.held_local) ? 'Yes' : 'No'

However, fields must be wrapped in a .field.span-17 div

If a book does not have an ISBN, no matter what you enter it will show up as the Social Network. It’s possible to edit the entry after the fact, but not right off the bat.

Visit /donors/:id and click the tossed books. The parameter is capitalized when it should be.

Remove the rubbish from when it was an included module. Filters by attribute can be handled by passing attributes as parameters instead of using scopes.

Extract recommendation changes into a Books::RecommendationController with an update action and refactor.

If the item is held locally, it should poll Voyager to pull statistics including:

1. how many copies
2. number of circulations

When making a decision on a book. Users should have the option of indicating the book should be kept, trashed, sold, or undecided.

There are multiple book controllers which have relatively identical code. It would be advantageous to refactor them using ActiveSupport::Concerns

Original question:
http://groups.google.com/group/boston-rubygroup/browse_thread/thread/7afdc9b880314906#

DHH Example:
https://gist.github.com/1014971

ThoughtBot Clearance Gem Example:
https://github.com/thoughtbot/clearance/blob/master/lib/clearance/authentication.rb

• change .find_by_isbn to .attributes_for_isbn
• make options variable a constant
• handle specific errors, otherwise explain the collection of errors handled