briceburg / jqmodal Goto Github PK

jqModal.js_focus.diff.txt
I am putting these two issues together because my patch covers both.
I imagine you might want to rework it.

1. focusFunc does not run at the right time for an ajax modal, should run after content is loaded.
2. When pressing tab and shift-tab, focus does not stay strictly within the modal.

minor issue: The code is indented with a mixture of tabs (width 2) and spaces.

Hi,

I'm using the jQuery version (v.2.1.4) and the last jqModal version (+r25) on a website. Everything works fine except to close a modal when I'm calling it with trigger. I was thinking about a conflict problem but it seems there is the same problem on the demo website : trying the example n°2 (AJAX) it's impossible to close the modal by clicking on the differents links...

When occurs double-clicking on the item, jqmOverlay hiding and jqmWindow can not be closed.

You say:
"NOTE: $.jqm() is usually called ONCE per modal. Subsequent calls to $.jqm() will update the modal(s) options using jQuery.extend()".

Am I misreading this? you say that subsequent calls will update the modal(s) options. I dont believe this is working.

I am converting a website to use jqmodal and need to use the old javascript function to call the modal. But the ajax option is not being updated after the first call. see simple simple example below which passes the current time to the text page.

function getpostbox(){

var d=new Date().getTime();
var strurl = 'testajax.asp?dte='+d;

$('#ex2').jqm({ajax:strurl, modal:true}).jqmShow({ overlay: 70 });  

}

You have defined the registration function as
(function(jQuery, window, undefined) {

However later you are using $ as jQuery variable so this parameter has no sense. Correct would be:
(function($, window, undefined) {

So that people can set different jQuery object if needed (see jQuery NoConflict as why this is important).

Mitja

I'm not at ease with github for the moment.

But the solution is to add a "var"

From
// maintain legacy "hash" construct
h = {w: e, c: o, o: v, t: t};

To
// maintain legacy "hash" construct
var h = {w: e, c: o, o: v, t: t};

If there are two modals to be opened, with the first one has modal:true, the input on the second modal cannot be focused. The plunker demonstrated the problem: http://plnkr.co/edit/ojo2xspL1oMnauSzKeCu?p=preview

I have been using this plugin since r14 in my iPad webclip/webapp without issue.
However I've noticed that since I've updated my iPad to ios8 that this plugin is now incompatible with my codebase.

To be more specific, when the jqmodal dialog is opened a fatal crash occurs that causes my webapp to exit completely!

I will try to debug this issue and provide an update; but if someone has any ideas I'd very much appreciate hearing them!

Thanks,
Tony

Why not expose ActiveModals collection? it will make it easier to recalculate css on window resize for example.

hi
just wondering in which browsers and browser versions does the jqmModal work?
thanks!

I believe there is an issue using jqModal on a page that has multiple forms. It looks like the initialization process: $('selector').jqm(options) builds a view model with properties for each target, the selector returns. Whereas the show: $('selector').jqmShow() slots the target of the selector into the page's form via .prependTo('form') creating copies of each modal in each of the page's forms. If for instance, you targeted a single modal on the page, but the page had two forms: The view modal would contain data for one modal, but after jqmShow() the page would contain two modals - one in each of the forms.

Hi,

I am trying the examples locally but I don't see any links for images. Could you please package everything together (css, images, and js) and provide for download?

http://jquery.iceburg.net/jqModal/#examples

Thanks

Can you please add a version field to package.json so the plugin can be installed via npm?

A main field would be useful too.

http://blog.npmjs.org/post/112712169830/making-your-jquery-plugin-work-better-with-npm

Thanks!

Because focus() is being called AGAIN on esc-binding

I've got a modal where I'm trying to get information and/or manipulate the modal's trigger (like add a class to it). In the modal's JS, I have a line that looks like this:

hash.w.addClass('foo');

This line attaches the "foo" class to the modal element when the modal is triggered.

Based on this, I thought I could do something similar to add the "foo" class to the triggering element, like so:

hash.t.addClass('foo');

However, this generates the following error:

Uncaught TypeError: hash.t.addClass is not a function

Is there a way to manipulate the modal's trigger, or perform other jQuery functions on it, like get the value of any "data" attributes that it might have?

I recently upgraded jqModal from r14 to r24.

I'm experiencing the same issue described in this Stack Overflow question: http://stackoverflow.com/questions/29395113/cannot-type-into-text-input-on-jqmodal-dialog-when-modal-set-to-true and the same fix (comment out modal:true).

However, since we are on r24, I'm confused, since your Stack Overflow answer indicates that it was fixed in r23.

Additionally, this changes the functionality of the software I'm writing, since clicking outside the modal didn't previously close the modal. This may or may not be a big deal to the product owners, but I wanted to open this issue to hopefully get some more information before approaching them about it.

Thanks,

Matt

Right now, the show event is cancellable if you return false onShow, but the click event needs to be cancellable as well, because I would want to make few checks before loading an Ajax source, so is there a way?

Since upgrading to +r23, buttons on modal dialogs don't work on the iPad - when you tap them a flashing text cursor appears on the left hand side of the button, as if the browser thinks it is a text input. +r24 doesn't fix it. In +r22 it worked fine.

to top is not appending to the body as it should in ie8. works fine in ie9+.. is this intended bryce? do you still support ie8 with jqmodal?

div.jqm({
    toTop: true,
    modal: true,
    overlay: 100,
}).jqmShow();