briantanner / eris-lavalink Goto Github PK

What license is this project licensed under?
I would want to use snippets of the code in my library.

I see in LavaLink jar file a reference to playlist but I see nothing about playlist in Eris-Lavalink. Is there an undocumented feature or Eris-Lavalink or does Eris-Lavalink not support any of Lavalinks playlist features?

I will go to get the lavalink client running but when I have it trying to connect to my host (which is just a a express http server) it gives me socket hang up when the host responds just fine. This is the code for the host.

'use strict';

const express = require('express');
const app = express();
module.exports = (client) => {
  app.get('/', (req, res) => res.send('Hello world!');

  app.listen(8080, () => console.log(`Listening on port 8080`));
};

I am trying to run a music bot, and it works great for only one song. When I try to use player.play(track) after the previous song ended, it emits end earlier than expected. Let's say I make the bot play a song, then queue another song after that. It finishes the first song, then goes onto the second song. Halfway through the second song, the player suddenly emits end even though the audio wasn't finished playing. Here is a picture of what console looks like when I let the song finish, and close up, then I play another song and let it rejoin:

This is what console looks like when I try to queue multiple songs after each other:

As you can see, it emits end twice before it even lets the second song end and the third song start. The reason it emits the error is because it called end before it let the other songs play, caused on my end of this. Here's my code: https://h.mayo.pw/exasojulos.js. I hope this helps, thanks!

So for a while, my skip command would just end the current track by using .stop() on the player, causing the end event to fire wher I had code to play the next track. At some point I thought:

shouldn't I just .play() with a new track?

I can. But, this causes issues that I can't seem to figure out.

So there are 2 scenarios:

1. (my old way of skipping or going to the next song for any reason)

• play() a track - it plays.
• end event works, inside the event i have code to go to the next song
• if somebody skips, I just stop() the player, and the end event fires, again playing the next song

2. (new way where I "replace" tracks)

• play() a track - it plays.
• end event works, inside the event i have code to go to the next song
• if somebody skips, instead of stopping the player, which forces the end event to fire, I just play() the next track.
• The track will play, BUT the end event will not fire for this track.

Also strange:
in the second scenario, the first and only the first track that i .play() while another is playing (rather than stopping to force the end event) will cause the end event to fire twice (yes, it is .once()). 2 identical data with "REPLACED" reason.
Calling play() while a song is playing subsequent times, the end event will fire with the "REPLACED" reason once as expected, however the "FINISHED" end event will never fire for any of these.

Edit: I think I figured out why this happens:
When playing the next track, the player starts and registers all the listeners (which are .once) before the end event with reason "REPLACED" occurs. Therefore, when the "REPLACED" event fires, both the .once listener stops listening to the end of the track and never sees the "FINISHED" event.

My sketchy solution (for now) was to make it a .on and remove all listeners imemdiately before doing .play(), then re-registering them afterwards as normal. This prevents the situation above.

Hello. I just recently started using Lavalink, and I love it! I believe it's a great audio library, and it greatly decreased CPU usage. The only problem I have is when I try to use player.setPause(), it does nothing. No logs or errors, nothing. Here's my code: https://h.mayo.pw/ugogibamuv.js. I don't know what causes this, but it never works. Any help?

Note: This isn't my production code, I'm just messing around with Lavalink at the moment.

NPM install does not work.

https://www.npmjs.com/package/eris-lavalink

Only way to currently install is via github.

I ran my bot, and then it gave me this error:
events.js:167
throw er; // Unhandled 'error' event
^

Error: unexpected server response (404)
at ClientRequest._req.on (/root/TrinityAlpha/node_modules/ws/lib/WebSocket.j s:653:21)
at ClientRequest.emit (events.js:182:13)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:538:21 )
at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)
at Socket.socketOnData (_http_client.js:425:20)
at Socket.emit (events.js:182:13)
at addChunk (_stream_readable.js:277:12)
at readableAddChunk (_stream_readable.js:262:11)
at Socket.Readable.push (_stream_readable.js:217:10)
at TCP.onread (net.js:638:20)
Emitted 'error' event at:
at Map.onError (/root/TrinityAlpha/node_modules/eris-lavalink/src/PlayerMana ger.js:142:21)
at Lavalink.emit (events.js:182:13)
at WebSocket.ws.on (/root/TrinityAlpha/node_modules/eris-lavalink/src/Lavali nk.js:77:9)
at WebSocket.emit (events.js:182:13)
at WebSocket.finalize (/root/TrinityAlpha/node_modules/ws/lib/WebSocket.js:1 82:41)
at ClientRequest._req.on (/root/TrinityAlpha/node_modules/ws/lib/WebSocket.j s:653:12)
at ClientRequest.emit (events.js:182:13)
[... lines matching original stack trace ...]
at TCP.onread (net.js:638:20)

For some reason (probaly due to my own code), playermanager's join function seems to be called twice, and the settimeout return value is being overwritten and as a result only the second one is being cancelled.

My modifacations


only console.log was added
I'll be posting reproduction code in a few hours

Not quite sure how to solve this.

TypeError: fn is not a function
    at Map.processQueue (/Users/air/Documents/Adonis/node_modules/eris-lavalink/src/PlayerManager.js:125:9)
    at Map.queueFailover (/Users/air/Documents/Adonis/node_modules/eris-lavalink/src/PlayerManager.js:115:25)
    at Map.shardReady (/Users/air/Documents/Adonis/node_modules/eris-lavalink/src/PlayerManager.js:160:18)
    at emitOne (events.js:120:20)
    at Object.emit (events.js:210:7)
    at Function.shard.on (/Users/air/Documents/Adonis/node_modules/eris/lib/gateway/ShardManager.js:56:29)
    at new Func (/Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/term.js:3053:19)
    at Function.Term.expr (/Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/term.js:2339:12)
    at /Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/term.js:2364:40
    at Object.loopKeys (/Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/helper.js:56:14)
    at Function.Term.expr (/Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/term.js:2362:12)
    at /Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/term.js:2364:40
    at Object.loopKeys (/Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/helper.js:56:14)
    at Function.Term.expr (/Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/term.js:2362:12)
    at /Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/term.js:2364:40
    at Object.loopKeys (/Users/air/Documents/Adonis/node_modules/rethinkdbdash/lib/helper.js:56:14)

player.connection is the Player class, however paused seems to be always undefined?

As the title says, Lavalink 2.x got released and eris-lavalink doesn't support it yet.

Changes in 2.x: https://github.com/Frederikam/Lavalink/blob/master/IMPLEMENTATION.md#changes-v13---v20

There is no volume property within the player. Maybe can you add one?

implementing the use of this into a bot, after extended usage of the bot playing on one guild i was presented with the following on the console down below, the bot has kept on playing and those events now have upwards of 80 listeners registered. is this a bug with the lib or my code?

(node:36915) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 disconnect listeners added. Use emitter.setMaxListeners() to increase limit
(node:36915) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added. Use emitter.setMaxListeners() to increase limit
(node:36915) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 stuck listeners added. Use emitter.setMaxListeners() to increase limit

That error still happen, did you already know the problems? I need to use this package

https://abal.moe/Eris/docs/Client#event-error

Eris' error event emits a id parameter of the shard ID that the error occured on (or -1 if not applicable)

Happens here: https://github.com/briantanner/eris-lavalink/blob/develop/src/PlayerManager.js#L143, possibly other places