Git Product home page Git Product logo

Comments (2)

briansmith avatar briansmith commented on June 19, 2024

PR #1908 attempts to resolve the mk/check-symbol-prefixes.sh parts.

from ring.

briansmith avatar briansmith commented on June 19, 2024
  • mk/{install-build-tools.sh, should not do install_packages llvm-$llvm_version

It still needs to, but only when we are in $use_clang mode.

Instead we should install the tools using rustup +$toolchain toolchain component add llvm-tools-preview before the coverage runs. This would require us to parse "+$toolchain" out of the command line, much like we parse "--target=$target". We'd need to update ci.yml accordingly to pass +${{ matrix.rust_channel }} on the command line.

Done in PR #1980.

In mk/check-symbol-prefixes.sh, we should similarly switch to using the llvm-tools-preview llvm-nm, and change ci.yml accordingly.
We should change the conditional logic in ci.yml so that mk/check-symbol-prefixes.sh is run for apple targets, where it is currently being skipped.

Done in PR #1908.

from ring.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.