Git Product home page Git Product logo

Comments (2)

briansmith avatar briansmith commented on July 19, 2024

I don't have a problem with adding this, but I don't have cycles to do the work on it, so somebody would need to contribute it.

  • The format of the internal state should be opaque to the API. The API should export/import a slice of bytes. This means we need to pick an endianness for the bytes. I suggest little endian, since that's less work for most targets.
  • We shouldn't try to serialize digest::Algorithm or ``digest::AlgorithmId. Instead the user should pass in the &digest::Algorithm`. The user will need to be responsible for keeping track of what algorithm goes to which bytes.
  • The APIs should be named "....less_safe()`.
  • We should have tests that exercise every algorithm, in the same style as the existing digest tests.

from ring.

anatse avatar anatse commented on July 19, 2024

PR - #2081

from ring.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.