brazzy / kohana-transactional Goto Github PK

Does the module work correctly when HMVC sub-requests are used (see http://kohanaframework.org/3.3/guide/kohana/flow )?

The test application doesn't run on Kohana 3.0 - bootstrap has to be changed, but even then it produces an empty page

Currently, any application-registered shutdown-function that accesses the DB happens outside the transaction and is rolled back. According to the PHP docs, it should be possible to have a shutdown function be executed after all others by registering it inside a shutdown function, but this does not seem to work, perhaps because the auto-rollback of the DB driver has already happened at that point.

In Spring, transactional methods can be marked read-only - it would be great to offer the same feature

Currently it doesn't work at all because the Request class now evaluates the route in the execute method rather than in the constructor.

In order to do the Right Thing naturally, the decision whether to commit or rollback should depend partially or completely on the HTTP return code (2xx=commit, 5xx=rollback, what about others?)

This would allow using die/exit when handling errors inside an action.

Is it necessary to have lines 43 and 44 in https://raw.github.com/brazzy/kohana-transactional/master/classes/Transactional/Request/Client/Internal.php

Kohana::$log->add(Log::ERROR, $prefix.$controller);
Kohana::$log->write();

My log files are getting filled with error messages for every controller action.

2013-04-09 07:58:28 --- ERROR: Controller_Logs in /var/www/system/classes/Kohana/Request.php:990