Git Product home page Git Product logo

Comments (21)

LaurenWags avatar LaurenWags commented on September 23, 2024 3

Discussed this issue with @stephendonner @MadhaviSeelam and added release/blocking and put it in the 1.66.x milestone as this doesn't reproduce on 1.65.x. We should resolve prior to releasing 1.66.x. cc @rebron @kjozwiak for visibility and in case you feel differently - we can adjust labels/milestone 👍🏻

from brave-browser.

stephendonner avatar stephendonner commented on September 23, 2024 1

It seems like it could be a caching error, but I'm not sure. Does it repro in another profile?

Reproduces 100% in a clean profile, for me.

from brave-browser.

sangwoo108 avatar sangwoo108 commented on September 23, 2024 1

Gotcha! On my intel machine, it was reproducible. I suspect something was wrong while rolling out the beta. Maybe webpack dependency? But not sure who can look into this. (Niglty works fine)

image

from brave-browser.

fallaciousreasoning avatar fallaciousreasoning commented on September 23, 2024 1

Going to be interesting to see what happens when the new Beta comes out. Hopefully this just disappears?

from brave-browser.

sangwoo108 avatar sangwoo108 commented on September 23, 2024 1

I checked but my dev version was okay. We're asking folks about the build machine here https://bravesoftware.slack.com/archives/C01EVLWS8R5/p1713744910635809

from brave-browser.

stephendonner avatar stephendonner commented on September 23, 2024 1

@stephendonner not sure but can we get a build artifact from https://ci.brave.com/job/test-brave-browser-build-macos-x64/1189/ and see if it repros?

(built on the same machine)

Asked in https://bravesoftware.slack.com/archives/C61QQMWS3/p1714498857856599

from brave-browser.

fallaciousreasoning avatar fallaciousreasoning commented on September 23, 2024

So this doesn't repro for me in 1.66.80 in Linux. However, we've been seeing a few of these ChunkLoadErrors which is worrying me a bit. I wonder what's causing them.

from brave-browser.

fallaciousreasoning avatar fallaciousreasoning commented on September 23, 2024

It seems like it could be a caching error, but I'm not sure. Does it repro in another profile?

from brave-browser.

sangwoo108 avatar sangwoo108 commented on September 23, 2024

On my mac, both beta and nightly works well.

from brave-browser.

fallaciousreasoning avatar fallaciousreasoning commented on September 23, 2024

I'm worried it's a build/installer problem. Does reinstalling the same version change anything @stephendonner?

from brave-browser.

stephendonner avatar stephendonner commented on September 23, 2024

I'm worried it's a build/installer problem. Does reinstalling the same version change anything @stephendonner?

I think it's using Morpheon Dark: https://chromewebstore.google.com/detail/morpheon-dark/mafbdhjdkjnoafhfelkjpchpaepjknad (now that I've retraced my steps); can you and @sangwoo108 try installing that, and see if the new-page page/Customize dialogs are broken/

from brave-browser.

fallaciousreasoning avatar fallaciousreasoning commented on September 23, 2024

Hmmm, still works for me - that would've been a neat solution though. Does it work for you when you remove it?

image

It'd be weird though, 'cause I don't think extensions can run on chrome:// urls

from brave-browser.

fallaciousreasoning avatar fallaciousreasoning commented on September 23, 2024

I wonder if this could be related to the React 18 upgrade

from brave-browser.

sangwoo108 avatar sangwoo108 commented on September 23, 2024

Yeah, it works for me with the theme(Nightly)

from brave-browser.

sangwoo108 avatar sangwoo108 commented on September 23, 2024

@stephendonner I'm cuirous what you see when you type "chrome://newtab/314.chunk.js" to the location bar? And also curios if you're uising intel mac or arm

from brave-browser.

stephendonner avatar stephendonner commented on September 23, 2024

@sangwoo108 here you go, thanks for asking!

@stephendonner I'm cuirous what you see when you type "chrome://newtab/314.chunk.js" to the location bar? And also curios if you're uising intel mac or arm

Screenshot 2024-04-18 at 5 29 44 PM

Intel macOS-x64, Big Sur:

Brave | 1.66.82 Chromium: 124.0.6367.60 (Official Build) beta (x86_64)
-- | --
Revision | 5dc8a11fe47f7e764f9108c665f3276805497669
OS | macOS Version 14.5 (Build 23F5059e)

from brave-browser.

sangwoo108 avatar sangwoo108 commented on September 23, 2024

Interesting, I'm not sure it should be same but my beta returns different source for the address. I've checked using my arm machine. I'll try checking using intel mac and let you know

from brave-browser.

stephendonner avatar stephendonner commented on September 23, 2024

Going to be interesting to see what happens when the new Beta comes out. Hopefully this just disappears?

Happens with the latest nightly

Brave	1.67.23 Chromium: 124.0.6367.60 (Official Build) nightly (x86_64) 
Revision	2574e866fb941a93ad6414bb02563c9ecb9fa9d5
OS	macOS Version 11.7.10 (Build 20G1427) 

too 😢

from brave-browser.

fallaciousreasoning avatar fallaciousreasoning commented on September 23, 2024

@sangwoo108 does this happen in Dev for you on your Intel mac?

from brave-browser.

fallaciousreasoning avatar fallaciousreasoning commented on September 23, 2024

@stephendonner not sure but can we get a build artifact from https://ci.brave.com/job/test-brave-browser-build-macos-x64/1189/ and see if it repros?

(built on the same machine)

from brave-browser.

stephendonner avatar stephendonner commented on September 23, 2024

@fallaciousreasoning Tested using https://build-artifacts.brave.com/test-brave-browser-build-macos-x64/1189/Brave-Browser-Nightly-x64.dmg

Cannot reproduce using:

Big Sur 11.7.10

Brave 1.67.29 Chromium: 124.0.6367.60 (Official Build) nightly (x86_64)
Revision 87978a973dbc82c83fc1f20ab9ec943862c388ed
OS macOS Version 11.7.10 (Build 20G1427)

Sonoma 14.5

Brave 1.67.29 Chromium: 124.0.6367.60 (Official Build) nightly (x86_64)
Revision 87978a973dbc82c83fc1f20ab9ec943862c388ed
OS macOS Version 14.5 (Build 23F5064f)

from brave-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.