Git Product home page Git Product logo

Comments (8)

deeppandya avatar deeppandya commented on September 22, 2024 1

@hffvld i tried the steps on 1.67.73. and it seems to be working as expected. only thing i noticed is that if desktop mode is enabled, it still shows Shorts in the left panel menu. Would you please add a recording if you can still reproduce the issue for more context ?

from brave-browser.

deeppandya avatar deeppandya commented on September 22, 2024 1

@hffvld i have added the relaunch here : brave/brave-core#23523.

from brave-browser.

ryanbr avatar ryanbr commented on September 22, 2024

Want to check this again @hffvld is it fixed?

from brave-browser.

hffvld avatar hffvld commented on September 22, 2024

I checked the latest Nightly 1.67.70 and it looks like the same behavior exists. There are 3 methods to refresh the page:

  • Full refresh by tapping the Refresh button
  • Full refresh by swiping down in the upper part of the YT page
  • Just the content refresh without refreshing the whole page by swiping down in the middle of the page

Shorts presence/absence is not changed when using the third method as before.

from brave-browser.

ryanbr avatar ryanbr commented on September 22, 2024

From my testing in Galaxy Tab; https://www.youtube.com/watch?v=EaMI2bc2zCw

I'm seeing no shorts after scrolling, with shields up.

from brave-browser.

hffvld avatar hffvld commented on September 22, 2024

I checked it again on Galaxy Tab S8 & Pixel 7 with Brave Nightly 1.67.77 and still see the same issue. It's possible to refresh the whole YT page and just the content on the page. In first case you'll see an orange refresh spinner, in the second case you'll see a white refresh spinner.

Whole page refresh Content refresh
1 2

I feel that customrs who uses a tablet will be more affected then these who uses a phone, because this issue is happening only in Desktop view which is ON on the tablet, but OFF on the phone by default

timestamp_13-48-07_13-48-39.mp4
timestamp_14-06-01_14-06-51.mp4

I talked to @deeppandya and we agreed that we can explicitly ask user to relaunch Brave as we do for some of the other features like Widevine DRM or Enable bottom bar, for example. This way we'll be on a safe side and know for sure that the changes are applied.

Example for Widevine DRM

1 2
1 2

cc @kjozwiak @Uni-verse

from brave-browser.

kjozwiak avatar kjozwiak commented on September 22, 2024

The above requires 1.66.105 or higher for 1.66.x verification 👍

from brave-browser.

hffvld avatar hffvld commented on September 22, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 14 AP31.240322.023 release-keys
Brave build: 1.66.105
Chromium: 125.0.6422.41 (Official Build) (64-bit) 

STEPS:

  1. Launch Brave 1.66.105 or newer
  2. Go to www.youtube.com > Confirm that Shorts are shown on the Home, Trending and Search tab
  3. Three-dot menu > Settings > Media
  4. Block YouTube Shorts > Enable it > Relaunch now
  5. Verify

ACTUAL RESULTS:

  • Verified that Shorts are not shown on the Home, Trending and Search tabs when Block YouTube Shorts toggle switch is ON
  • Verified that pop-up message saying that changes will be applied after Brave relaunch is shown when toggling Block YouTube Shorts ON or OFF
  • Verified that Shorts are not shown in both Mobile and Desktop view when Block YouTube Shorts is ON

Galaxy Tab S8
1 2
1 2
1 2
1 2
1 2
2024-05-13_16-21-15.mp4
Pixel 7
OFF ON
1 2
1 2
1 2
1 2
2024-05-13_16-01-21.mp4

from brave-browser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.