Comments (8)
@hffvld i tried the steps on 1.67.73. and it seems to be working as expected. only thing i noticed is that if desktop mode is enabled, it still shows Shorts
in the left panel menu. Would you please add a recording if you can still reproduce the issue for more context ?
from brave-browser.
@hffvld i have added the relaunch here : brave/brave-core#23523.
from brave-browser.
Want to check this again @hffvld is it fixed?
from brave-browser.
I checked the latest Nightly 1.67.70
and it looks like the same behavior exists. There are 3 methods to refresh the page:
- Full refresh by tapping the
Refresh
button - Full refresh by
swiping down
in theupper part
of the YT page - Just the content refresh without refreshing the whole page by
swiping down
in themiddle of the page
Shorts
presence/absence is not changed when using the third method as before.
from brave-browser.
From my testing in Galaxy Tab; https://www.youtube.com/watch?v=EaMI2bc2zCw
I'm seeing no shorts after scrolling, with shields up.
from brave-browser.
I checked it again on Galaxy Tab S8
& Pixel 7
with Brave Nightly 1.67.77
and still see the same issue. It's possible to refresh the whole YT page
and just the content on the page
. In first case you'll see an orange
refresh spinner, in the second case you'll see a white
refresh spinner.
Whole page refresh | Content refresh |
---|---|
I feel that customrs who uses a tablet will be more affected then these who uses a phone, because this issue is happening only in Desktop view
which is ON on the tablet, but OFF on the phone by default
timestamp_13-48-07_13-48-39.mp4
timestamp_14-06-01_14-06-51.mp4
I talked to @deeppandya and we agreed that we can explicitly ask user to relaunch
Brave as we do for some of the other features like Widevine DRM
or Enable bottom bar
, for example. This way we'll be on a safe side and know for sure that the changes are applied.
Example for Widevine DRM
1 | 2 |
---|---|
from brave-browser.
The above requires 1.66.105
or higher for 1.66.x
verification 👍
from brave-browser.
Verified on Galaxy Tab S8
and Pixel 7
using version(s):
Device/OS:
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 14 AP31.240322.023 release-keys
Brave build: 1.66.105
Chromium: 125.0.6422.41 (Official Build) (64-bit)
STEPS:
- Launch Brave
1.66.105
or newer - Go to www.youtube.com > Confirm that
Shorts
are shown on theHome
,Trending
andSearch
tab - Three-dot menu > Settings > Media
- Block YouTube Shorts > Enable it > Relaunch now
- Verify
ACTUAL RESULTS:
- Verified that
Shorts
are not shown on theHome
,Trending
andSearch
tabs whenBlock YouTube Shorts
toggle switch is ON - Verified that pop-up message saying that changes will be applied after Brave relaunch is shown when toggling
Block YouTube Shorts
ON or OFF - Verified that
Shorts
are not shown in bothMobile
andDesktop
view whenBlock YouTube Shorts
is ON
from brave-browser.
Related Issues (20)
- Add iOS News MAU/DAU metrics
- [Follow up to #37348] When device language/region is set to the allowlisted country (ex. USA) it is possible to enable `Rewards` for `Russia` and `Ukraine` HOT 6
- Update wallet portfolio chart to remove allow-same-origin sandbox attribute
- [Android] Parallel downloading setting HOT 1
- [ads] Favicon found report to rewards if when `shouldNotifyAdsServiceTabContentDidChange` is false
- Action Extension not triggering for txt file
- Enable Bitcoin by default on iOS HOT 1
- The secure status icon for unknown SSL status is wrong on iOS HOT 2
- Long title text of a Bookmark in the Bookmarks list is missing and/or faded out
- Search engine favicon should be updated when a different search engine is selected via customize dashboard HOT 1
- Disabling `Close window when closing last tab` breaks `Bring all tabs to this window` functionality. HOT 3
- [CR 126] change `Switch to this tab` text/border colour - follow up of #38731 HOT 2
- [CR 126] Enable `Reading List` sub menu HOT 2
- [ZCash] Switch to another zcash endpoint HOT 3
- (Feature) Single-window mode
- Address bar appearance bug
- [ads] Brave News inline ads with the same placement id are shown in new tabs
- Leo - Add system standard context menu for query entry field
- Test failure: TransactionConfirmationStoreTests.testPrepareBTCSend()
- [iOS] - Support Multi-Device Skus Payments
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brave-browser.