Comments (2)
sangwoo108
commented on May 23, 2024
Wow, @ShivanKaul well spotted. I assume "keep for offline playing" just checks "uncached" itmes and queue the tasks. That's why it's retriggered as many times as "kepp for offline playing" was clicked.
from brave-browser.
stephendonner
commented on May 23, 2024
Verification PASSED using
Brave | 1.67.45 Chromium: 124.0.6367.91 (Official Build) nightly (x86_64)
-- | --
Revision | f5b8b1597695a9fa4b57874e2a469ef8ad62ff48
OS | macOS Version 11.7.10 (Build 20G1427)
Followed the steps to reproduce from #37469 (comment)
Confirmed no Keep for offline playing option while downloading
Confirmed no refetching after Remove offline data was chosen
| example | example | example |
|---|---|---|
 |
 |
 |
| example | example | example |
|---|---|---|
 |
 |
 |
from brave-browser.
Related Issues (20)
- [ads] db error: 1034/disk I/O error (SQLITE_IOERR_FSYNC) HOT 1
- [ads] db error: 1299/NOT NULL constraint failed: creative_ads.creative_instance_id
- [ads] db error: 778/disk I/O error (SQLITE_IOERR_WRITE) HOT 1
- [ads] db error: 1/sql::Database is not opened.
- [ads] db error: 266/disk I/O error (SQLITE_IOERR_READ) HOT 1
- Leo - Carry over design styles from Context menu to Browser settings
- iOS not reporting browser uptime metric
- Add an explicit "Block connections without VPN" setting to VPN (VPN kill switch)
- [iOS] Add an explicit "Block connections without VPN" setting to VPN (VPN Kill Switch Toggle)
- Unsolicited connections to Google
- [Follow up to #36465] YT `Shorts` is not removed by the `swiping down` method when refreshing the page while YT is in `Desktop mode`
- [ads] Failed to purge orphaned ad events
- [ads] Failed to purge expired ad events
- [ads] NTT video ad Play button overlaps with `Show More` button on iPhone SE 2
- leo not correctly escaping backticks in output
- Truncate long token names and balances
- Built-in adblocker must have feature parity with uBlock Origin
- Invalid request when using Chrome Identity API / Google OAuth Screen in the extension: Custom URI scheme is not supported on Chrome apps HOT 1
- Brave shares fingerprint across different profiles
- Option to "Always open links in a private tab"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brave-browser.