brarcher / rental-calc Goto Github PK

@brarcher i am wondering whether this is https://github.com/brarcher/rental-calc#note-from-developer still relevant ;)

I'm a PhD student interested in finding security vulnerabilities in open source projects.

We found a total of 3 warnings (indicating potential vulnerabilities) when running the CogniCrypt static analyzer (*) on rental-calc (or its library dependencies). We documented these issues in private gists for the sake of confidentiality (non-disclosure).

Can you please let us know whether we can share these gists with you? We are eager to evaluate the perception of developers (e.g. severity of these warnings) and improve rental-calc's security, and the quality of the reports of static analysis tools.

(*) https://github.com/CROSSINGTUD/CryptoAnalysis

Recent releases of Android do not support sending file URI paths through intents. This app needs to be updated to use providers to share images and to not use raw file paths to get images.

Open About dialog and rotate screen, WebView disappears. Even though it's may not be a bug, the app can be more professional and user experience can be improved if WebView persist after screen orientation change.

Screenshot before device rotation

Screenshot after device rotation

Tested on Android 23 with Nexus 4 emulator.