brandonwu / moira Goto Github PK

Hi, many dependencies needs some updating and this needs a LICENSE file for those who want to fork and update the code.

Your Readme says that this library has been broken by changes in authentication, yet the most recent commit claims to have fixed that. Will this work in its current state, and will it give me Rads?

Hi, I looked at your code and found the following to be confusing:

order_url = 'http://www.marketwatch.com/game/msj-2013/trade/'
'submitorder?week=1'

It seems that you hard-coded the game name 'msj-2013' in the order method of moira module. Shouldn't it be value of game parameter?

Also, I don't understand what does 'week=1' mean, would you please explain?

Hi,

I found a bug in moira.search_stock function, here is your code:

time = datetime.strptime(r.headers['date'],'%a, %d %b %Y %H:%M:%S %Z')
time = time.replace(tzinfo=from_zone).astimezone(to_zone)

The time format is not correct, month of returned from server is actually a string, like 'April', not an integer between 1 and 12, this would throw an Exception when you run it.

I suggest using code as follows:

from datetime.parser import parse
time = parse(r.headers['date'])

This works fine on my machine. Everything else works great so far. :-)