bradwj / friend-advisor Goto Github PK

Create a header component for all pages that has a return arrow (iOS users QOL)

When attempting to delete a group, the delete confirmation covers the entire screen, so the user cannot see the group name that they must type.

• frontend
• backend

With more and more users, we should optimize our firebase use to save money. Caching is a great way to avoid redundant functions calls and firestore reads.

One of the ways to do this is to query firestore for most recently updated documents before the previous cache, using lastUpdated property in docs.

• Leave group - delete events in local cache

Local storage methods:
https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API
https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API
https://developer.mozilla.org/en-US/docs/Web/API/Cache

Improve phone number input

Currently there is no input validation for when a user inputs a phone number. The Twilio API requires phone numbers to begin with a plus sign, followed by the country code, followed by the rest of the phone number (e.g. "+11234567899", where +1 is the country code, and 123-456-7899 is the user's phone number).
One way to improve the user input is to require the user to specify a country code, and then enter their phone number. There may already be a built in phone number input form? We should make sure they are entering all of the digits of the number and without any extra symbols such as parenthesis or dashes.

/test is an endpoint that we use to test the notification sending service, it should be secured so that only specific users can run it.

When a request is sent to the backend for a user to be removed from a group, we can check if there are no users in the group after the user is removed, and then call the function to delete the group itself.

In the function to delete a group, we can call a function that removes any events from that group as well.

Add an ability for a user to upload or take a picture as their avatar.

• upload photo
• take photo
• replace existing stock photos with uploaded photo

Generate smaller join codes for groups that make it easier for users to join.

Add time to display along with the date in events view for each event.

On the backend, a method for /groups/join will be added to take two params: userId and joinId, then add the userId to the group's members.

• frontend
• backend

Once a group is empty, what should happen?

Page did not redirect after clicking create, document was added to database but member was added as undefined.
Attempt was on mobile device.

Also on mobile device, profile would not load.

The current groupId is not copyable in the mobile app, so it needs a "copy to clipboard" button.

Sometimes the app does not render out the components because it is fetching data. A waiting screen can inform the user of the fetching.

As discussed with @heartgg , we need to move profile update requests (from account page) to the backend.

It would be cool feature if users could create events that only they themselves get notified for, without having to be in any specific group or create a group beforehand.

Depending on the date of the event, change the color based on the closeness of that date to today.

Users should have the ability to edit group names.

Remove button currently redirects you to the event page.
Intended behavior is that it removes an event from the events page.

Had an issue with the location not saving for creating a new event.

Saving, removing, and editing should have a double confirmation from the user.

Add an approximate time (i.e. in 1 day, in 4 hours) to the event cards.

Add functionality to have new events be added to the device's calendar
https://ionicframework.com/docs/v3/native/calendar/

Text notifications are by default sent out a month before, week before, day before, and on the day of the event. We should allow users to choose which days or on how many days before that notifications should be sent.
I'm thinking that we'll restructure the documents for events too have their sentNotifications look something like this:

sentNotifications: [
  { 
    hoursBefore: 24, // day of
    usersNotified: [<array of user IDs>]
  },
  {
    hoursBefore: 48, // day before
    usersNotified: [<array of user IDs>]
  },
  {
    hoursBefore: 168, // week before
    usersNotified: [<array of user IDs>]
  },
  {
    hoursBefore: 720, // month before
    usersNotified: [<array of user IDs>]
  },
]

This could be how the default notification schedule will look, but the user should have the option to define their own.

We could add a function to the notification scheduler that will do the following:

• remove events from groups that don't exist
• remove groups that have no members
• remove groups whose joinId was not generated (The function will set the joinId to "" if it cannot create an id within 50 attempts)

When an event is made, the creator of the event should be added to the card.

basically title. if an event has passed, there should be a button to view past events instead of having expired events displayed on the main page.

I was sent a notification saying "You have ____ today!" on 2/17, 7pm, when the event is on 2/18, 7pm.

The code needs to be updated to make sure the DAY is the same for this notification to be sent. Right now the code just checks if it is within 24 hours.

no more document access from frontend code max.....

The user should be able to type in a city or address when choosing an event location. Also, the user should be able to add a custom location, which doesn't specify a location on the map, and instead just displays the user input next to the location.
For example, say a friend group wants to meet up at Dining Hall West. They should have the option to specify a location on the map, or instead just use "Dining Hall West" as the data point for the location of the event.

• add endpoint
• add frontend
• add confirmation dialog (see also #29 )

RSVP button would be responsible for counting how many people RSVP an event.

• backend
• frontend

We should have reasonable limits in place for how quickly people can:

• join groups (prevent guessing join codes)
• create events
• edit events
• edit groups
• delete groups / events
• get data for a group

Pretty much everything should be covered here, but different endpoints should have different limits

There are currently many css files that are empty. Should there be a single css file with all of the styling that we would like in our app?

Add an 'about' page that has information about:
-Project members, with photos, names, and their contributions
-How we came up with the idea (hackathon)

• Make middleware to authenticate (@realprogrammer5000 )
• Remove usage of user id parameter in backend and use middleware authentication
• Make helper function in frontend to handle authenticated requests
• Remove usage of user id parameter in frontend, replace with token
• Authenticate user membership on group modification endpoints (@demonlexe )

After a user has inputted a valid phone number (see issue #18), we need to send a verification code to the entered phone number, and request the user to input the verification code in the app. This way we can confirm that user's are using their own phone numbers and aren't inputting someone else's to spam them with notifications.

Let the user know which group is responsible for which event.

Groups should be able to have short descriptions about themselves. I already added backend support for this, so now it just needs to be supported on the frontend.

• frontend
• backend

Phone numbers are currently displayed on user profiles in the exact manner that the user inputted their phone number. I'm thinking that we should display their phone number in a more readable format, for example +1 (123) 456-7899

Additionally, users should be able to make their phone numbers private, so that it is not publicly displayed on their profile.

Event descriptions should be optional, but when no description is inputted, it stores "undefined" as the description instead.

The optional event description also needs to be handled in the backend when sending the messages through Twilio. Currently when no description is present, the message contains "Description: undefined" but instead, no description label should be sent.

• frontend
• backend