boswall / content-author-accessibility-preview Goto Github PK

If user install the plugin and looking for the settings options, it would be good to add a link to the settings into the plugin description.

I tried the plugin out with a few other plugins enabled. One was Shortcodes Ultimate.

Shortcodes Ultimate creates a number of shortcodes including "buttons" (really links styled as buttons). Here's an example:

[su_button url="https://content-accessibility.local" target="self" style="default" background="#2D89EF" color="#FFFFFF" size="3" wide="no" center="no" radius="auto" icon="" icon_color="#FFFFFF" text_shadow="none" desc="" onclick="" rel="" title="" id="" class=""]Button text[/su_button]

Here's the rendered code:
<a href="https://content-accessibility.local" class="su-button su-button-style-default" style="color:#FFFFFF;background-color:#2D89EF;border-color:#246ebf;border-radius:5px;-moz-border-radius:5px;-webkit-border-radius:5px" target="_self"><span style="color:#FFFFFF;padding:0px 16px;font-size:13px;line-height:26px;border-color:#6cacf4;border-radius:5px;-moz-border-radius:5px;-webkit-border-radius:5px;text-shadow:none;-moz-text-shadow:none;-webkit-text-shadow:none"> Button text</span></a>

I noticed that Content Author Accessibility Preview marks this as a "link opens new window" even though the target attribute is set to self. When you add a "button" in this way, there's a dropdown, with the options Open in new tab or Open in same tab, so you can't avoid adding the target attribute altogether. You could remove it from the shortcode afterwards, but most users won't know how to do that.

Therefore, in content-author-accessibility-preview.php line 171, would it be better to have 'selector' => $container . ' a[target=_blank]', rather than 'selector' => $container . ' a[target]', ?

When the plugin is first activated, no user roles appear to be selected in the settings page.

I can then select one or more and press Save Settings.

Then if I deselect all of them and press Save Settings, all of them are checked.

currently the check results are displayed only visually. In this way Screenreader Users can't use the checker. It would be great if the plugin would also be accessible for blind users, because some accessibility consultants are blind.

I have noticed that problem because it got mentioned in a newsletter from a blind accessibility consultant.

Need to make sure that all the checkboxes in the settings page have attached labels. Nesting the checkbox inside the label is OK but you still need the explicit id/for connection. And the convention for checkboxes is that the label should follow the checkbox.

There are currently only 2 colours used (red and gold) to show the issues. I think this was to denote the severity of the issues.

This does not give any details of what the issue is (only that an issues exists) and means that the usability of the plugin is very limited. You have to inspect an element to know what the issue is.

My plan was to add a title attribute to the highlighted elements so that users could hover over them to see a description. However, elements with title attributes are something that is highlighted in the CSS and not very accessible.

Another option would be to add an ::after pseudo element with some text. This would only show one issue at a time and may break some themes (if the theme uses the pseudo element).

Another option would be to use different colours for each type of issue and add a legend for users to refer to.

Any other thoughts?

As has been noted before, Content Authors might not know why an element is being highlighted as an accessibility issue. A suggestion from @grahamarmfield is to have a sentence or two that might explain the issue either with the issue label or at the bottom of the content / page.

I will have a try with both of these options but I think attaching the explanations to the page would be best from a technical and usability point.

@abrightclearweb , would I be ok to take some of the explanations from your write-up on the plugin? You described the issues much better than I could.